[ http://issues.apache.org/jira/browse/GERONIMO-2381?page=comments#action_12433475 ] Paul McMahan commented on GERONIMO-2381: ----------------------------------------
Vamsi, comments on this patch: Instead of prompting the user with the form's internal variable names it would be more helpful to use the display name or say something like "please specify a database name". Also, there is already code on the server to check for non-empty SQL, and it displays a message that matches the display name. I suggest either removing the client side check for SQL introduced in this patch or make the client side prompt use the form's display name. > DB Manager portlet - Form field validation using javascript > ----------------------------------------------------------- > > Key: GERONIMO-2381 > URL: http://issues.apache.org/jira/browse/GERONIMO-2381 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Components: console > Affects Versions: 1.1.1 > Environment: WinXP, G 1.1.1-rc1 > Reporter: Vamsavardhana Reddy > Fix For: 1.2, 1.1.x, 1.1.2 > > Attachments: GERONIMO-2381.patch > > > Form field validation in DB Manager portlet using javascript. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
