[ http://issues.apache.org/jira/browse/GERONIMO-2383?page=comments#action_12433680 ] Gianny Damour commented on GERONIMO-2383: -----------------------------------------
It seems that there is a small issue with the patch: AxisBuilder does not more implement ServiceReferenceBuilder; however, its GBeanInfo still declares this interface has been implemented. This causes a small problem when trying to load the axis-builder module. Anyway, simply need to remove it manually. I still need to do some testings; thought, by reviewing the change sets, it seems to be a great refactoring. Althought, it seems that it is possible to have a successful deployment which is actually not successful (for instance if a NamingBuilder is wrongly stopped, then some naming elements may not be honored.). > Replace ENCConfigBuilder with a pluggable set of NamingBuilders > --------------------------------------------------------------- > > Key: GERONIMO-2383 > URL: http://issues.apache.org/jira/browse/GERONIMO-2383 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Affects Versions: 1.2 > Reporter: David Jencks > Assigned To: David Jencks > Fix For: 1.2 > > Attachments: GERONIMO-2383-openejb-v2.patch, GERONIMO-2383-v2.patch > > > (Previously part of GERONIMO-2349) > The ENCConfigBuilder is way too hardcoded into what it accepts and how. It > won't let you add things like a persistence-ref builder very easily. We can > replace it with a set of NamingBuilders somewhat similar to > NamespaceDrivenBuilders. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
