Hey Tim you may want to check out this wiki page for coding standards and best practices. It also has some tips on logging: http://cwiki.apache.org/GMOxDEV/coding-standards.html
Best wishes, Paul On 9/19/06, Tim McConnell <[EMAIL PROTECTED]> wrote:
Thanks for the info David and Jason, I already assigned myself the G-1404 jira related to some logging problems, so I'll use that to try to clean this up. I've noticed also a lot of inconsistencies in how logging is and isn't used. I also hope that there are coding standards and/or best practices that should be adhered to. Thanks. Jason Dillon wrote: > On Sep 19, 2006, at 12:04 PM, David Jencks wrote: >> I think there is something strange going on with log4j >> configuration. To get a reasonable level of coverage in any log >> (console or file) I have to remove/comment out the line >> >> log4j.logger.org.apache.geronimo.gbean.runtime.GBeanSingleReference=DEBUG >> > > Um, this seems very fishy... > > >> In my limited experimentation that line prevents logging just about >> anything else at debug (and possibly info) no matter what the >> "global" settings are. > > But, the logging config in G is a bit temperamental as I found when I > was trying to get logging for tests to work as it should when using > log4j configuration. > > There is some code in geronimo-kernel which will insert Log4j > configuration, which negates some of the configuration that should be > picked up from log4j.properties. It may be worth spending a bit of > time to clean that up, maybe removing the custom injection of logging > objects, and using a separate log4j-debug.properties or something > along those lines to allow -v or -vv to install the desired logging > config. > > --jason >
