[ http://issues.apache.org/jira/browse/GERONIMO-2458?page=comments#action_12440018 ] Vamsavardhana Reddy commented on GERONIMO-2458: -----------------------------------------------
The current MapEditor won't work at all. Whereas the fix I submitted is alright as long as there are no null keys or values. I agree that my patch will make the class equivalent to "MapEditor extends PropertiesEditor" with nothing extra. Maps can have null keys & values and null mapped to null. Keys and values need not be Strings. MapEditor should handle all these scenarios. I submitted the patch with the idea that I will sumbit another patch later to handle nulls etc. Each key and its corresponding value in Properties is a String. If we will not be handling non-string properties or values and nulls in maps in G, we can remove this class altogether and use PropertiesEditor alone. > MapEditor does not work > ----------------------- > > Key: GERONIMO-2458 > URL: http://issues.apache.org/jira/browse/GERONIMO-2458 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: common > Affects Versions: 1.1.1, 1.2 > Environment: 1.2-SNAPSHOT > Reporter: Vamsavardhana Reddy > Fix For: 1.1.2, 1.2 > > Attachments: GERONIMO-2458.patch > > > MapEditor.getAsText() is returning map.toString() which is not in sync with > setAsText() that expects input in the form name1=value1 on separate lines. > Bottom line... > MapEditor.getAsText() returns > {name1=value1, name2=value2} > where as MapEditor.setAsText() expects > name1=value1 > name=value2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
