Re: svn commit: r472998 - /geronimo/server/trunk/modules/geronimo-connector-builder/src/main/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilder.java

[David Jencks]

-1 on this, see comment on commit notice in branches/1.1

thanks
david jencks

On Nov 9, 2006, at 10:08 AM, [EMAIL PROTECTED] wrote:

Author: vamsic007
Date: Thu Nov  9 10:08:00 2006
New Revision: 472998

URL: http://svn.apache.org/viewvc?view=rev&rev=472998
Log:

GERONIMO-1986 TranQL Connector doesn't check Driver Class during deployment

Modified:

geronimo/server/trunk/modules/geronimo-connector-builder/src/ main/java/org/apache/geronimo/connector/deployment/ ConnectorModuleBuilder.java

Modified: geronimo/server/trunk/modules/geronimo-connector-builder/ src/main/java/org/apache/geronimo/connector/deployment/ ConnectorModuleBuilder.java URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ geronimo-connector-builder/src/main/java/org/apache/geronimo/ connector/deployment/ConnectorModuleBuilder.java? view=diff&rev=472998&r1=472997&r2=472998 ====================================================================== ======== --- geronimo/server/trunk/modules/geronimo-connector-builder/src/ main/java/org/apache/geronimo/connector/deployment/ ConnectorModuleBuilder.java (original) +++ geronimo/server/trunk/modules/geronimo-connector-builder/src/ main/java/org/apache/geronimo/connector/deployment/ ConnectorModuleBuilder.java Thu Nov 9 10:08:00 2006

@@ -822,6 +822,19 @@

         // ManagedConnectionFactory

setDynamicGBeanDataAttributes (managedConnectionFactoryInstanceGBeanData, connectiondefinitionInstance.getConfigPropertySettingArray(), cl);

+

+ //Check if Driver class is available here. This should be available in cl. If not throw a deployment error as + //the plan gets deployed and while starting GBean an error is thrown

+

+ String driver = (String) managedConnectionFactoryInstanceGBeanData.getAttribute("Driver");

+        if (driver != null) {
+            try {
+                cl.loadClass(driver);
+            } catch (ClassNotFoundException e1) {
+                throw new DeploymentException(e1);
+            }
+        }
+
         try {
             if (resourceAdapterAbstractName != null) {

managedConnectionFactoryInstanceGBeanData.setReferencePattern ("ResourceAdapterWrapper", resourceAdapterAbstractName);