[ https://issues.apache.org/activemq/browse/SM-736?page=comments#action_37435 ] Grant McDonald commented on SM-736: -----------------------------------
The question is which is the preferred resource adapter the one on the endpoint or the one on the activation spec? resourceAdapter = endpoint.getResourceAdapter(); if (resourceAdapter == null) { resourceAdapter = activationSpec.getResourceAdapter(); if (resourceAdapter == null) { throw new IllegalArgumentException("resourceAdapter not set"); } } else if (activationSpec.getResourceAdapter() == null) { activationSpec.setResourceAdapter(resourceAdapter); } resourceAdapter.start(bootstrapContext); resourceAdapter.endpointActivation(endpointFactory, activationSpec); In the code you have modified above there is a condition which has side effects: - the endpoint resource adapter is not null; and - the activation spec resource adapter is not null in this case the resource adapter that is started and used in endpoint activation is the one from the endpoint. Guillaume: which should have precedence? The one from the endpoint or the one defined on the activation spec? > JcaConsumerProcessor.start() fails after subsequent stop() > ---------------------------------------------------------- > > Key: SM-736 > URL: https://issues.apache.org/activemq/browse/SM-736 > Project: ServiceMix > Issue Type: Bug > Components: servicemix-jms > Affects Versions: 3.1 > Environment: Windows XP, JBoss 4.0.4 GA > Reporter: Frank Trietsch > Fix For: 3.1 > > Attachments: JcaConsumerProcessor.java > > > When a JMS-SU ist stopped and reactivated then the start() method fails with > the following exception: > java.lang.IllegalArgumentException: resourceAdapter not set > at > org.apache.servicemix.jms.jca.JcaConsumerProcessor.start(JcaConsumerProcessor.java:92) > This due to a wrong check in the start() method. A fixed version is attached. > Regards, > Frank -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira