geronimo-k

Joe Bohn Wed, 13 Dec 2006 20:22:24 -0800

Anita,

Are these changes completed? I'm hitting an error with attempting tostart the servers from a fresh trunk build and they might be related(but then again I'm not feeling well and I'm pretty tired ... so I couldhave something messed up locally). Here's the failure:


Booting Geronimo Kernel (in Java 1.5.0_06)...

23:12:51,538 WARN [ConfigurationUtil] Could not load gbeanorg.apache.geronimo.configs/j2ee-system/2.0-SNAPSHOT/car?ServiceModule=org.apache.geronimo.configs/j

2ee-system/2.0-SNAPSHOT/car,j2eeType=AttributeStore,name=AttributeManager

org.apache.geronimo.gbean.InvalidConfigurationException: Target does nothave specified method (declared in a GBeanInfo operation):name=hasGBeanAttributes methodName=hasGBeanAttributes returnType=booleantargetClass=org.apache.geronimo.system.configuration.LocalAttributeManageratorg.apache.geronimo.gbean.runtime.GBeanOperation.<init>(GBeanOperation.java:98)atorg.apache.geronimo.gbean.runtime.GBeanInstance.<init>(GBeanInstance.java:298)atorg.apache.geronimo.kernel.basic.BasicKernel.loadGBean(BasicKernel.java:354)atorg.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:363)atorg.apache.geronimo.kernel.config.ConfigurationUtil.loadBootstrapConfiguration(ConfigurationUtil.java:155)atorg.apache.geronimo.kernel.config.ConfigurationUtil.loadBootstrapConfiguration(ConfigurationUtil.java:126)atorg.apache.geronimo.system.main.Daemon.doStartup(Daemon.java:242)

        at org.apache.geronimo.system.main.Daemon.<init>(Daemon.java:74)
        at org.apache.geronimo.system.main.Daemon.main(Daemon.java:366)
[  ]  0%   1s Startup failed

org.apache.geronimo.kernel.config.InvalidConfigException: Unknown startexceptionatorg.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:444)atorg.apache.geronimo.kernel.config.ConfigurationUtil.loadBootstrapConfiguration(ConfigurationUtil.java:155)atorg.apache.geronimo.kernel.config.ConfigurationUtil.loadBootstrapConfiguration(ConfigurationUtil.java:126)atorg.apache.geronimo.system.main.Daemon.doStartup(Daemon.java:242)

        at org.apache.geronimo.system.main.Daemon.<init>(Daemon.java:74)
        at org.apache.geronimo.system.main.Daemon.main(Daemon.java:366)

Caused by: org.apache.geronimo.gbean.InvalidConfigurationException:Target does not have specified method (declared in a GBeanInfooperation): name=hasGBeanAttributes methodName=hasGBeanAttributes returnType=booleantargetClass=org.apache.geronimo.system.configuration.LocalAttributeManageratorg.apache.geronimo.gbean.runtime.GBeanOperation.<init>(GBeanOperation.java:98)atorg.apache.geronimo.gbean.runtime.GBeanInstance.<init>(GBeanInstance.java:298)atorg.apache.geronimo.kernel.basic.BasicKernel.loadGBean(BasicKernel.java:354)atorg.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:363)

        ... 5 more

        at org.apache.geronimo.system.main.Daemon.<init>(Daemon.java:74)
        at org.apache.geronimo.system.main.Daemon.main(Daemon.java:366)

        ... 5 more
Server shutdown begun
Server shutdown completed

Thanks,
Joe



anita kulshreshtha wrote:

Thanks Dain!

--- Dain Sundstrom <[EMAIL PROTECTED]> wrote:

On Dec 12, 2006, at 5:32 AM, anita kulshreshtha wrote:

Thanks Gianny, David J and Dain for providing feedback. I could


have

certainly used it before commiting rev 485321. IIUC, here is whatneeds
to be done:
1. .....Make the necessary code changes to
GBeanInfoBuilder while keeping the signatures of addOperation


methods same.

API compatibility - yes

   Serialization compatibility - depends on GOparationInfo

2. GoperationInfo must contain a field named targetClass
(declaringClass?). There are 2 options:
  a.. Just add the field and maintain backward compatibility



       API compatibility - yes
       Serialization compatibility - yes

  b.. Clean the code, i.e. remove unused field methodName and


break

the compatibility.



       API compatibility - no
       Serialization compatibility - no
    Even in Geronimo GOperationInfo does not seem to be used outside of
the kernel, hence it will be safe to remove the constructors without
the targetClass. I think we should not allow incomplete GOpeartionInfo
objects. But then I do not know what is the protocol for fixing the
API...

Which backward compatibility API, serialization or both?
I prefer we don't break backwards compatibility in the GBean apissince they are used everywhere.
    I am leaning towards b.
3. The fact that in some cases GBeanInfoBuilder.addInterfaces()
Line
295 ends up with two methods with same name and signatures but
different return type, it is not by design. Most of the time it is
due
to a badly overridden getter/setter/operation, and it is not the
responsibility of GBeanInfoBuilder to flag that as an error.
In Java5 a method is allowed to override/implement a method with areturn type that is more specific. For example:
public interface Intf {
  Object getSomething();
}

public class Clazz implements Intf {
  public String getSomething() {
      return "something"
  }
}

-dain



  Ah.. java 5... One more question :)
    Why do we allow bad operations in GBeanInfo ? For example it is
possible to add a non existent operation to GBeanInfo.

Thanks
Anita

____________________________________________________________________________________

Any questions? Get answers on any topic at www.Answers.yahoo.com.  Try it now.

Re: svn commit: r485321 - in /geronimo/server/trunk/modules: geronimo-kernel/src/main/java/org/apache/geronimo/gbean/ geronimo-kernel/src/main/java/org/apache/geronimo/gbean/runtime/ geronimo-kernel/src/test/java/org/apache/geronimo/gbean/ geronimo-k

Reply via email to