[
https://issues.apache.org/jira/browse/GERONIMO-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477738
]
David Jencks commented on GERONIMO-2735:
----------------------------------------
I worked on trunk (2.0) and reworked the patch substantially. There's now a
small example in the geronimo-jetty6-jee5 config.xml.
rev 514355.
features:
- jexl expressions in ${} such as ${httpPort + portOffset}
- expressions are only evaluated when gbeanData overrides are being applied,
not on set.
- default properties file is var/config/config-substitutions.properties
- refactored most of the LocalAttributeManager related classes to use generics.
If no one objects or has a better idea in a few days I'll make more extensive
use of this feature in our config.xmls.
I don't think it's practical to try to get this into the 1.2 branch.
> Add property substitution capability in the config.xml and plan files
> ---------------------------------------------------------------------
>
> Key: GERONIMO-2735
> URL: https://issues.apache.org/jira/browse/GERONIMO-2735
> Project: Geronimo
> Issue Type: New Feature
> Security Level: public(Regular issues)
> Affects Versions: 1.1.1, 1.1.x, 2.0-M1
> Environment: All
> Reporter: Ted Kirby
> Assigned To: David Jencks
> Priority: Minor
> Attachments: JIRA2735.1.1.1.patch, JIRA2735.2.0.patch
>
>
> Allow property substitution as it works in maven, Spring, and JBoss.
> Allow a geronimo.properties type file. In that file, allow something like
> this:
> tomcat.port=9090
> tomcat.listen.ip=10.0.0.7
> In the config.xml, then allow the following:
> ...
> <module name="...">
> <gbean name="TomcatConnector">
> <attribute name="port">${tomcat.port}</attribute>
> <attribute name="host">${tomcat.listen.ip}</attribute>
> </gbean>
> </module>
> The server reads the property file on boot (if one exists). When the
> config.xml is processed, it substitutes the declared property.
> Properties might also come from a GBean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
