i am using dependency management for most of the stuff. However, keep in mind, devtools is a very unique case. I sometime depend on multiple versions of a given module, so sometimes use of properties is required.

Prediciting your next response on why multiple versions are needed...

Every release of the G plugins provide cumalative support for previous version of Geronimo. So while Geronimo moves on with development, forgetting prior releases, from a tooling perspective I cannot do that. So while trunk it geronimo implies "2.0 and 2.0" only. Trunk in devtools implies "1.0, 1.1.x, and 2.0 support on the latest version of WTP (installable as individual features).

-sachin


On Apr 16, 2007, at 4:36 PM, Jason Dillon wrote:

You really should use the dependencyManagement feature of maven 2 to manage versions, please don't use properties like this.

--jason


On Apr 16, 2007, at 1:30 PM, [EMAIL PROTECTED] wrote:

Author: sppatel
Date: Mon Apr 16 13:30:21 2007
New Revision: 529386

URL: http://svn.apache.org/viewvc?view=rev&rev=529386
Log:
allow eclipse install location to be passed

Modified:
geronimo/devtools/eclipse-plugin/trunk/plugins/ org.apache.geronimo.runtime.common/pom.xml
    geronimo/devtools/eclipse-plugin/trunk/pom.xml

Modified: geronimo/devtools/eclipse-plugin/trunk/plugins/ org.apache.geronimo.runtime.common/pom.xml URL: http://svn.apache.org/viewvc/geronimo/devtools/eclipse-plugin/ trunk/plugins/org.apache.geronimo.runtime.common/pom.xml? view=diff&rev=529386&r1=529385&r2=529386 ===================================================================== ========= --- geronimo/devtools/eclipse-plugin/trunk/plugins/ org.apache.geronimo.runtime.common/pom.xml (original) +++ geronimo/devtools/eclipse-plugin/trunk/plugins/ org.apache.geronimo.runtime.common/pom.xml Mon Apr 16 13:30:21 2007
@@ -29,6 +29,7 @@
     <properties>
         <xbeanVersion>2.0.0</xbeanVersion>
         <commonsLoggingVersion>1.0.4</commonsLoggingVersion>
+        <geronimo_spec_version>1.0</geronimo_spec_version>
     </properties>
     <build>
         <resources>

Modified: geronimo/devtools/eclipse-plugin/trunk/pom.xml
URL: http://svn.apache.org/viewvc/geronimo/devtools/eclipse-plugin/ trunk/pom.xml?view=diff&rev=529386&r1=529385&r2=529386 ===================================================================== =========
--- geronimo/devtools/eclipse-plugin/trunk/pom.xml (original)
+++ geronimo/devtools/eclipse-plugin/trunk/pom.xml Mon Apr 16 13:30:21 2007
@@ -73,7 +73,7 @@
         </site>
     </distributionManagement>
     <properties>
-<!-- Feature Versions -->
+ <eclipseInstall>${settings.localRepository}/eclipse</ eclipseInstall> <org.apache.geronimo.feature_version>2.0.0</ org.apache.geronimo.feature_version> <org.apache.geronimo.v10.feature_version>2.0.0</ org.apache.geronimo.v10.feature_version> <org.apache.geronimo.v11.feature_version>2.0.0</ org.apache.geronimo.v11.feature_version>
@@ -81,8 +81,6 @@
<org.apache.geronimo.v20.feature_version>2.0.0</ org.apache.geronimo.v20.feature_version> <org.apache.geronimo.installableruntime.tomcat.feature_version>2.0.0< /org.apache.geronimo.installableruntime.tomcat.feature_version> <org.apache.geronimo.installableruntime.jetty.feature_version>2.0.0</ org.apache.geronimo.installableruntime.jetty.feature_version>
-<!-- Ext. Jar Dependency Versions -->
-        <geronimo_spec_version>1.0</geronimo_spec_version>
     </properties>
     <dependencyManagement>
         <dependencies>
@@ -120,7 +118,7 @@
                             </goals>
                             <configuration>
<markersDirectory>../../target/ dependency-maven-plugin-markers</markersDirectory> - <outputDirectory>$ {settings.localRepository}/eclipse</outputDirectory> + <outputDirectory>${eclipseInstall} </outputDirectory>
                                 <artifactItems>
                                     <artifactItem>
<groupId>org.eclipse.gef</ groupId>
@@ -332,4 +330,4 @@
         <module>features</module>
         <module>assembly</module>
     </modules>
-</project>
+</project>
\ No newline at end of file




Reply via email to