[ 
https://issues.apache.org/jira/browse/GERONIMO-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donald Woods resolved GERONIMO-3151.
------------------------------------

    Resolution: Fixed

Committed revision 537265 in trunk.
Updated remaining builders to use LinkedList<String> like the others were.
Updated all builders to use configurationDir.getAbsolutePath() when a file 
could not be removed, instead of relying on toString() to be called.


> DeploymentUtil.recursiveDelete(File,Collection) is returning a collection of 
> File objects, whereas most builders are expecting Strings
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3151
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3151
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0-M6
>         Environment: Java5 on Linux
>            Reporter: Donald Woods
>         Assigned To: Donald Woods
>             Fix For: 2.0-M6
>
>
> Was seeing the following in the server log -
> 22:11:43,058 ERROR [Deployer] Deployment failed due to -
> java.lang.ClassCastException: java.io.File incompatible with java.lang.String 
>         at 
> org.apache.geronimo.j2ee.deployment.EARConfigBuilder.cleanupConfigurationDir(EARConfigBuilder.java:682)
>  
>         at 
> org.apache.geronimo.j2ee.deployment.EARConfigBuilder.cleanupContext(EARConfigBuilder.java:669)
>  
> Which can be fixed by having DeploymentUtil.recursiveDelete() return a 
> collection of string by using file.getAbsolutePath().
> This also helps with repeated deploy/undeploy operations over several hours, 
> which eventual start to fail -
> 22:12:00,355 ERROR [LocalAttributeManager] IOException occurred while saving 
> attributes 
> java.io.IOException: Too many open files 
>         at java.io.File.createNewFile(File.java:876) 
>         at 
> org.apache.geronimo.system.configuration.LocalAttributeManager.save(LocalAttributeManager.java:374)
>  
>         at 
> org.apache.geronimo.system.configuration.LocalAttributeManager$2.run(LocalAttributeManager.java:600)
>  
>         at java.util.TimerThread.mainLoop(Timer.java:527) 
>         at java.util.TimerThread.run(Timer.java:477) 
> 22:12:00,985 ERROR [TransportConnector] Could not accept connection : 
> java.net.SocketException: Too many open files 
> java.net.SocketException: Too many open files 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to