[
https://issues.apache.org/jira/browse/GSHELL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532577
]
Guillaume Nodet commented on GSHELL-35:
---------------------------------------
Did you see my changes ?
I still use the CommandDescriptor but wrap it inside a Command, so the real
commands won't be created until actually executed.
Also, the command are now stateless because there is no more call to init().
Previously, one need to call
command.init(context)
command.execute(args)
This means that a single command is not thread safe (because the context is a
state stored in the command itself).
Now, you just need to call:
command.execute(context, args)
Please take a deeper look at the changes before reverting them (if you
considered doing so), as I don't think any of your concerns is actually true.
> Make CommandDescriptor optional and make Command stateless
> ----------------------------------------------------------
>
> Key: GSHELL-35
> URL: https://issues.apache.org/jira/browse/GSHELL-35
> Project: GShell
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: API, Core
> Affects Versions: 1.0-alpha-1
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
