Yup, sounds fine. As I mentioned to ya a while ago on IRC I took a few short cuts when I whipped this stuff up... after what now seems like a long time ago.

Anyways, go for it. Only comment I've got is you should call the intf CommandLineBuilder and the default impl DefaultCommandLineBuilder (prefix insteand of suffix to follow how the other components play... ).

--jason


On Oct 11, 2007, at 6:46 AM, Guillaume Nodet wrote:

I'm trying to configure GShell through spring because spring can
integrate nicely in OSGi (which is my main purpose) and I just crossed
one problem:  the CommandLineBuilder is a dependency of
DefaultCommandExecutor (in terms of POJOs).  The problem is that
CommandLineBuilder is a class, not an interface, with a strong
dependency on plexus.  So I'd like to introduce an interface
CommandLineBuilder and rename the class as the default implementation
CommandLineBuilderDefault.  Any objections ?

--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/

Reply via email to