[
https://issues.apache.org/jira/browse/GERONIMO-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543651
]
Jay D. McHugh commented on GERONIMO-1265:
-----------------------------------------
Committed revision 596403.
Here is a new set of changes that should hopefully finish fleshing out comment
support in config.xml.
1) If there is no 'top level' comment in config.xml then a default warning
comment will be inserted. Once there is a comment, it will be retained.
2) If you include a comment element in the pom.xml file of a module at the
GBean level, it will be carried over into the config.xml.
3) A comment added to config.xml at the module level will be retained.
Todo:
1) Figure out how a comment for the entire config.xml file can be placed into
the source and make sure that it makes it to the final config.xml.
2) Figure out how a comment for a full module (within) config.xml can be
placed into the source and make sure it makes it to the final config.xml).
> Preserve comments added by users in the config.xml file
> -------------------------------------------------------
>
> Key: GERONIMO-1265
> URL: https://issues.apache.org/jira/browse/GERONIMO-1265
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: startup/shutdown, usability
> Affects Versions: 1.0-M5, 1.0, 1.1, 2.1
> Reporter: John Sisson
> Assignee: Jay D. McHugh
> Attachments: geronimo-1265.patch
>
>
> Currently if a user adds comments to the config.xml file, they will be lost
> when Geronimo re-generates the file if a configuration change is made (e.g.
> through the web console).
> As a temporary measure, the code that re-generates the XML will place a
> warning at the top of the file warning users not to place comments in it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
