We should be careful about this too...  thanks craig!

Begin forwarded message:

From: Craig L Russell <[EMAIL PROTECTED]>
Date: November 21, 2007 12:12:54 PM PST
To: [EMAIL PROTECTED]
Subject: Apache requirements for commit message for contributed code
Reply-To: [EMAIL PROTECTED]

Recently, the Apache board reasserted the requirement that the commit message for code contributed by other than the committer must include attribution of the contributor. It's necessary, but not sufficient for the commit message to include the JIRA.

The rationale is to make sure that we can determine provenance for code without having to go beyond the svn repository.

Please see http://www.apache.org/dev/committers.html#applying-patches

For example, if Joe Schmo (not an Apache committer) submitted a patch, this is not ok:

commit -m "PROJECT-987 fix for NPE in constructor"

This is ok:

commit -m "PROJECT-987 fix for NPE in constructor, contributed by Joe Schmo"

Craig

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!


Reply via email to