[
https://issues.apache.org/jira/browse/GERONIMO-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554158
]
Erik B. Craig commented on GERONIMO-3714:
-----------------------------------------
Viet,
There is a problem with your patch
patching file
applications/monitoring/mconsole-war/src/main/webapp/WEB-INF/view/monitoringEditGraph.jsp
Hunk #1 FAILED at 73.
Hunk #2 FAILED at 96.
Hunk #3 FAILED at 113.
Hunk #4 FAILED at 157.
Hunk #5 FAILED at 168.
Hunk #6 FAILED at 219.
Hunk #7 FAILED at 457.
Hunk #8 FAILED at 525.
8 out of 8 hunks FAILED -- saving rejects to file
applications/monitoring/mconsole-war/src/main/webapp/WEB-INF/view/monitoringEditGraph.jsp.rej
> Monitoring console does no error checking on add/edit graph timeframe
> ---------------------------------------------------------------------
>
> Key: GERONIMO-3714
> URL: https://issues.apache.org/jira/browse/GERONIMO-3714
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Reporter: Erik B. Craig
> Assignee: Erik B. Craig
> Attachments: geronimo-3714.patch
>
>
> Currently the Monitoring console does no error checking on add/edit graph
> timeframe, it is therefore possible to define graphs that will break the page.
> There should be javascript checks to prevent the user from entering values
> anything less than 3*(snapshot duration) and anything more than the archive
> cutoff point, UNLESS 'show archive' is checked
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
