[
https://issues.apache.org/jira/browse/GERONIMO-3833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578142#action_12578142
]
Viet Hung Nguyen commented on GERONIMO-3833:
--------------------------------------------
Committed revision 636624 to 2.1 branch.
> Hard-coded gbean names and versions in monitoring code
> ------------------------------------------------------
>
> Key: GERONIMO-3833
> URL: https://issues.apache.org/jira/browse/GERONIMO-3833
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1, 2.1.1, 2.2
> Reporter: Jarek Gawor
> Assignee: Viet Hung Nguyen
> Fix For: 2.1.1, 2.2
>
>
> The monitoring code has hard-coded values in Java code and sql file:
> 1)
> The
> ./plugins/monitoring/mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MRCConnector.java
> contains the following constant:
> private static final String PATH =
> "geronimo:ServiceModule=org.apache.geronimo.plugins.monitoring/agent-car-jmx/2.1-SNAPSHOT/car,J2EEServer=geronimo,
> name=MasterRemoteControlJMX,j2eeType=GBean";
> 2)
> The
> ./plugins/monitoring/mconsole-ear/src/main/resources/MonitoringClientDB.sql
> contains a bunch of the following values:
> 'geronimo:J2EEServer=geronimo,ServiceModule=org.apache.geronimo.configs/tomcat6/2.1/car,j2eeType=GBean,name=TomcatWebConnector'
> I'm not sure how these are used but in general these type of hardcoded values
> should be avoided. It's really hard to maintain and keep track of.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
