On Thu, Apr 10, 2008 at 2:03 PM, Vasily Zakharov <[EMAIL PROTECTED]> wrote:
> No, I don't think is a Tortoise problem indeed. > It just proposes to add to the patch all new (not added to SVN) files > it sees in the working directory unless they're put to svn:ignore > lists. > Looks pretty logical and intuitive to me. :) Oh, ok. Yeah. I see that now. It is pretty nice, actually. My mistake. > > > Anyway, I'm not crying in despair :), I just see that in some cases > svn:ignore lists are properly maintained and include all the generated > directories, and in some cases they're not, and I think that it > probably worths to be consistent in this matter. :) > Sounds good to me. Thanks for clearing up my confusion! > > Vasily > > > On Thu, Apr 10, 2008 at 7:55 PM, Jason Warner <[EMAIL PROTECTED]> wrote: > > Alright. I was just curious why you were seeing an issue I wasn't. Now > > that I see you're using TortoiseSVN it all becomes clear ;) I liked > > tortoiseSVN's interface, it just has little bugs here and there that got > on > > my nerves too much. I'm inclined to think the issue is in how > tortoiseSVN > > is handling creating patches. I'm not opposed to the change, though. > Just > > curious, is all. Thanks for the info! > > > > ~Jason Warner > > > > > > > > On Thu, Apr 10, 2008 at 1:47 PM, Vasily Zakharov <[EMAIL PROTECTED]> wrote: > > > Well, I'm using TortoiseSVN and it always considers those files to be > > > added to the repository when I'm going to create a patch. > > > This obstructs a create patch/commit dialog with a lot of unneeded > > > entries, and increases the working copy scan time. > > > > > > In fact, I wouldn't raise this issue if I don't see that many other > > > 'target' and 'build' directories are put to svn:ignore lists, while > > > some are not. > > > > > > Vasily > > > > > > > > > > > > > > > > > > On Thu, Apr 10, 2008 at 7:18 PM, Jason Warner <[EMAIL PROTECTED]> > wrote: > > > > Hi Vasily, > > > > > > > > What do you mean by getting in the way? I've never had issues with > > this. > > > > What behavior are you seeing? > > > > > > > > ~Jason Warner > > > > > > > > > > > > > > > > On Thu, Apr 10, 2008 at 1:15 PM, Vasily Zakharov <[EMAIL PROTECTED]> > wrote: > > > > > > > > > When trying to create a patch in an already-built environment, a > lot > > > > > of build-generated directories get in the way. > > > > > Probably they need to be added to the corresponding SVN ignore > lists. > > > > > > > > > > I've created a GERONIMO-3957 for that, and provided patches for > trunk, > > > > > branches/2.1, branches/2.0 and tags/2.1.0. > > > > > > > > > > I hope it would be useful. > > > > > > > > > > Vasily > > > > > > > > > > > > > > > > > > > > > -- > > > > ~Jason Warner > > > > > > > > > > > -- > > ~Jason Warner > -- ~Jason Warner
