I'm seeing problems that need to be addressed.
RAT shows the following files are missing Apache src license headers:
=======================================================================
==./yoko-1.0/distribution/src/main/samples/ws/bank_ws_addressing/
BankWS-corba.idl
=======================================================================
=======================================================================
==./yoko-1.0/distribution/src/main/samples/ws/bank_ws_addressing/
BankWS-corba.wsdl
=======================================================================
=======================================================================
==./yoko-1.0/etc/third_party_licenses/CDDL-license.txt
=======================================================================
=======================================================================
==./yoko-1.0/etc/third_party_licenses/antlr-bsd-license.txt
=======================================================================
=======================================================================
==./yoko-1.0/etc/third_party_licenses/wsdl4j-cpl-license.txt
=======================================================================
=======================================================================
==./yoko-1.0/rmi-impl/pom.xml
=======================================================================
=======================================================================
==./yoko-1.0/rmi-spec/pom.xml
=======================================================================
=======================================================================
==./yoko-1.0/yoko-spec-corba/pom.xml
=======================================================================
The third_party_licenses files wouldn't need license headers, of
course. However, it doesn't look like we're actually including these
projects in the Yoko binaries. So, I think we should delete these
license files/directory (and any references to them).
The LICENSE files include the following license information:
Object Management Group (OMG) classes
/***** Copyright (c) 1999 Object Management Group. Unlimited
rights to
duplicate and use this code are hereby granted provided that
this
copyright notice is included.
*****/
I note that files such as yoko-1.0/yoko-spec-corba/src/main/java/org/
omg/Messaging/MaxHopsPolicyHelper.java have an Apache src license
header. Personally, I think they should not have an Apache src license
header. These files are not Apache licensed, they are OMG licensed.
Perhaps there's been discussion of this, in the past that you can
point me to?
--kevan
On May 8, 2008, at 9:11 AM, Rick McGuire wrote:
All,
I've prepared a release candidate of Geronimo Yoko ORB 1.0 for your
review and vote.
The source for the Yoko ORB release currently resides here:
https://svn.apache.org/repos/asf/geronimo/yoko/tags/yoko-1.0
This will also be the final tag version if the release vote is
approved.
The maven artifacts for the release can be found here:
http://people.apache.org/~rickmcguire/staging-repo/yoko
There are 4 different components involved here, the core, rmi-impl,
rmi-spec, and yoko-corba-spec. Each components has a jar file and
also generated javadoc and source jars. For convenience, the
artifacts can be located using these URLs:
http://people.apache.org/~rickmcguire/staging-repo/yoko/org/apache/yoko/yoko-core/1.0/
http://people.apache.org/~rickmcguire/staging-repo/yoko/org/apache/yoko/rmi-impl/1.0/
http://people.apache.org/~rickmcguire/staging-repo/yoko/org/apache/yoko/rmi-spec/1.0/
http://people.apache.org/~rickmcguire/staging-repo/yoko/org/apache/yoko/yoko-corba-spec/1.0/
When the release vote is approved, these maven artifacts will be
moved to the m2-ibiblio-rsync-repository at Apache.
[ ] +1 Release Geronimo 2.1.1
[ ] 0 No opinion
[ ] -1 Do not release Geronimo 2.1.1 (please provide rationale)
I'll plan on calling this vote on Monday morning (9 PM EST).
Rick
