Re: svn commit: r663607 - in /geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/main/webapp: TreeDocIcon.css WEB-INF/view/classloaderview/view.jsp WEB-INF/view/dependencyview/view.jsp WEB-INF/view/jndiview/view.jsp

Fri, 06 Jun 2008 12:20:04 -0700 

Lin,
When we commit code that was provided to us in a patch, we should provide an attribution within the commit message. In this case, something like: 


GERONIMO-4027 Patch from Joe Leong. Thanks Joe! Accessibility issue:  
Tree icons in high contrast mode cannot be seen



I may be a bit pedantic, but if you could revert your changes to 2.1  
and trunk and recommit, that would be great...


I would guess that our wiki doesn't document this...

--kevan
On Jun 5, 2008, at 9:36 AM, [EMAIL PROTECTED] wrote:


Author: linsun
Date: Thu Jun  5 06:36:46 2008
New Revision: 663607

URL: http://svn.apache.org/viewvc?rev=663607&view=rev
Log:

GERONIMO-4027 Accessibility issue: Tree icons in high contrast mode  
cannot be seen


Modified:

   geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/TreeDocIcon.css
   geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/WEB-INF/view/classloaderview/view.jsp
   geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/WEB-INF/view/dependencyview/view.jsp
   geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/WEB-INF/view/jndiview/view.jsp



Modified: geronimo/server/trunk/plugins/debugviews/debugviews- 
portlets/src/main/webapp/TreeDocIcon.css

URL: 
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/main/webapp/TreeDocIcon.css?rev=663607&r1=663606&r2=663607&view=diff

= 
= 
= 
= 
= 
= 
= 
= 
======================================================================
--- geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/TreeDocIcon.css (original)
+++ geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/TreeDocIcon.css Thu Jun  5 06:36:46 2008

@@ -14,12 +14,21 @@

*   See the License for the specific language governing permissions  
and

*   limitations under the License.

= 
= 
====================================================================*/

[EMAIL PROTECTED] url("../dojo/src/widget/templates/TreeDocIcon.css");
+
+/*

+File Not Used. The Widget Has Problems Referencing Using the  
templateCssPath

+

[EMAIL PROTECTED] url("http://localhost:8080/dojo/0.4/src/widget/templates/TreeDocIcon.css 
");

+
+.TreeIconDocument {

+	background-image: url(http://localhost:8080/debug-views/ico_filetree_16x16.gif 
);

+}

.TreeExpandOpen .TreeIconFolder {
-    background-image: url('./images/ico_filetree_16x16.gif');

+	background-image: url(http://localhost:8080/debug-views/ico_filetree_16x16.gif 
);

}

.TreeExpandClosed .TreeIconFolder {
-    background-image: url('./images/ico_filetree_16x16.gif');

+	background-image: url(http://localhost:8080/debug-views/ico_filetree_16x16.gif 
);

}
+*/


Modified: geronimo/server/trunk/plugins/debugviews/debugviews- 
portlets/src/main/webapp/WEB-INF/view/classloaderview/view.jsp

URL: 
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/main/webapp/WEB-INF/view/classloaderview/view.jsp?rev=663607&r1=663606&r2=663607&view=diff

= 
= 
= 
= 
= 
= 
= 
= 
======================================================================
--- geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/WEB-INF/view/classloaderview/view.jsp (original)
+++ geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/WEB-INF/view/classloaderview/view.jsp Thu Jun  5  
06:36:46 2008

@@ -332,16 +332,58 @@
</table>

<input type="submit" value='<fmt:message  
key="classloaderview.view.invertTree"/>' />

<br />
-
<div dojoType="TreeBasicControllerV3" widgetId="controller"></div>
<div dojoType="TreeSelectorV3" widgetId="selector"></div>
<div dojoType="TreeEmphasizeOnSelect" selector="selector"></div>
-<div dojoType="TreeToggleOnSelect" selector="selector"
- controller="controller"></div>
-<div dojoType="TreeDocIconExtension" widgetId="iconcontroller"

- templateCssPath="<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
TreeDocIcon.css") %>"></div>

-<div dojoType="TreeV3" listeners="controller;selector;iconcontroller"
- widgetId='tree' allowedMulti='false'></div>

+<div dojoType="TreeToggleOnSelect" selector="selector"  
controller="controller"></div>
+<div dojoType="TreeDocIconExtension" widgetId="iconcontroller"  
templateCssString="

+.TreeStateChildrenYes-ExpandOpen .TreeIconContent {
+    background-image : url('../templates/images/TreeV3/i_long.gif');
+    background-repeat : no-repeat;
+    background-position: 18px 9px;
+}
+
+.TreeStateChildrenYes-ExpandClosed .TreeIconContent {
+    background-image : url();
+}
+
+.TreeStateChildrenNo-ExpandLeaf .TreeIconContent {
+    background-image : url();
+}
+
+.TreeStateChildrenNo-ExpandClosed .TreeIconContent {
+    background-image : url();
+}
+
+.TreeStateChildrenNo-ExpandOpen .TreeIconContent {
+    background-image : url();
+}
+
+.TreeIconDocument {

+    background-image: url(<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
ico_filetree_16x16.gif") %>);

+}
+
+.TreeExpandOpen .TreeIconFolder {

+    background-image: url(<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
ico_filetree_16x16.gif") %>);

+}
+
+.TreeExpandClosed .TreeIconFolder {

+    background-image: url(<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
ico_filetree_16x16.gif") %>);

+}
+
+/* generic class for docIcon */
+.TreeIcon {
+    width: 18px;
+    height: 18px;
+    float: left;
+    display: inline;
+    background-repeat : no-repeat;
+}
+
+div.TreeContent {
+    margin-left: 36px;
+}"></div>

+<div dojoType="TreeV3"  
listeners="controller;selector;iconcontroller" widgetId='tree'  
allowedMulti='false'></div>


<div id="debug"></div>
</form>


Modified: geronimo/server/trunk/plugins/debugviews/debugviews- 
portlets/src/main/webapp/WEB-INF/view/dependencyview/view.jsp

URL: 
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/main/webapp/WEB-INF/view/dependencyview/view.jsp?rev=663607&r1=663606&r2=663607&view=diff

= 
= 
= 
= 
= 
= 
= 
= 
======================================================================
--- geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/WEB-INF/view/dependencyview/view.jsp (original)
+++ geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/WEB-INF/view/dependencyview/view.jsp Thu Jun  5 06:36:46  
2008

@@ -227,11 +227,57 @@
</td></tr>
</table>
<br/>
-
<div dojoType="TreeBasicControllerV3" widgetId="controller"></div>

<div dojoType="TreeSelectorV3" widgetId="selector"  
eventNames="select:nodeSelected"></div>

<div dojoType="TreeEmphasizeOnSelect" selector="selector"></div>

<div dojoType="TreeToggleOnSelect" selector="selector"  
controller="controller"></div>
-<div dojoType="TreeDocIconExtension"  widgetId="iconcontroller"  
templateCssPath="<%=  
renderResponse.encodeURL(renderRequest.getContextPath() +  
"TreeDocIcon.css") %>"></div>
+<div dojoType="TreeDocIconExtension"  widgetId="iconcontroller"  
templateCssString="

+.TreeStateChildrenYes-ExpandOpen .TreeIconContent {
+    background-image : url('../templates/images/TreeV3/i_long.gif');
+    background-repeat : no-repeat;
+    background-position: 18px 9px;
+}
+
+.TreeStateChildrenYes-ExpandClosed .TreeIconContent {
+    background-image : url();
+}
+
+.TreeStateChildrenNo-ExpandLeaf .TreeIconContent {
+    background-image : url();
+}
+
+.TreeStateChildrenNo-ExpandClosed .TreeIconContent {
+    background-image : url();
+}
+
+.TreeStateChildrenNo-ExpandOpen .TreeIconContent {
+    background-image : url();
+}
+
+.TreeIconDocument {

+    background-image: url(<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
ico_filetree_16x16.gif") %>);

+}
+
+.TreeExpandOpen .TreeIconFolder {

+    background-image: url(<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
ico_filetree_16x16.gif") %>);

+}
+
+.TreeExpandClosed .TreeIconFolder {

+    background-image: url(<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
ico_filetree_16x16.gif") %>);

+}
+
+/* generic class for docIcon */
+.TreeIcon {
+    width: 18px;
+    height: 18px;
+    float: left;
+    display: inline;
+    background-repeat : no-repeat;
+}
+
+div.TreeContent {
+    margin-left: 36px;
+}"></div>

<div dojoType="TreeV3"  
listeners="controller;selector;iconcontroller" widgetId='tree'  
allowedMulti='false'></div>


+


Modified: geronimo/server/trunk/plugins/debugviews/debugviews- 
portlets/src/main/webapp/WEB-INF/view/jndiview/view.jsp

URL: 
http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/main/webapp/WEB-INF/view/jndiview/view.jsp?rev=663607&r1=663606&r2=663607&view=diff

= 
= 
= 
= 
= 
= 
= 
= 
======================================================================
--- geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/WEB-INF/view/jndiview/view.jsp (original)
+++ geronimo/server/trunk/plugins/debugviews/debugviews-portlets/src/ 
main/webapp/WEB-INF/view/jndiview/view.jsp Thu Jun  5 06:36:46 2008

@@ -201,12 +201,57 @@
</td></tr>
</table>
<br/>
-
-
<div dojoType="TreeBasicControllerV3" widgetId="controller"></div>
<div dojoType="TreeSelectorV3" widgetId="selector"></div>
<div dojoType="TreeEmphasizeOnSelect" selector="selector"></div>

<div dojoType="TreeToggleOnSelect" selector="selector"  
controller="controller"></div>
-<div dojoType="TreeDocIconExtension"  widgetId="iconcontroller"  
templateCssPath="<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
TreeDocIcon.css") %>"></div>
+<div dojoType="TreeDocIconExtension"  widgetId="iconcontroller"  
templateCssString="

+.TreeStateChildrenYes-ExpandOpen .TreeIconContent {
+    background-image : url('../templates/images/TreeV3/i_long.gif');
+    background-repeat : no-repeat;
+    background-position: 18px 9px;
+}
+
+.TreeStateChildrenYes-ExpandClosed .TreeIconContent {
+    background-image : url();
+}
+
+.TreeStateChildrenNo-ExpandLeaf .TreeIconContent {
+    background-image : url();
+}
+
+.TreeStateChildrenNo-ExpandClosed .TreeIconContent {
+    background-image : url();
+}
+
+.TreeStateChildrenNo-ExpandOpen .TreeIconContent {
+    background-image : url();
+}
+
+.TreeIconDocument {

+    background-image: url(<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
ico_filetree_16x16.gif") %>);

+}
+
+.TreeExpandOpen .TreeIconFolder {

+    background-image: url(<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
ico_filetree_16x16.gif") %>);

+}
+
+.TreeExpandClosed .TreeIconFolder {

+    background-image: url(<%=  
renderResponse.encodeURL(renderRequest.getContextPath() + "/ 
ico_filetree_16x16.gif") %>);

+}
+
+/* generic class for docIcon */
+.TreeIcon {
+    width: 18px;
+    height: 18px;
+    float: left;
+    display: inline;
+    background-repeat : no-repeat;
+}
+
+div.TreeContent {
+    margin-left: 36px;
+}"></div>

<div dojoType="TreeV3"  
listeners="controller;selector;iconcontroller" widgetId='tree'  
allowedMulti='false'></div>


+


























					Reply via email to