On Jul 16, 2008, at 12:52 PM, Joe Bohn wrote:


David,

Can this change be merged into samples/branches/2.1 or is it dependent on changes in server/trunk that are not included in server/ branches/2.1?

These changes definitely depend on those in rev 664198. I'm of two minds about porting that back to branches/2.1. On the one hand its really kind of a bug, on the other hand it is a very noticeable structural change that is definitely not backward compatible.



Somewhere along the way the app-per-port sample started failing install in branches/2.1 and I was wondering if these changes (particularly the localhost changes) would correct the problem.

Here's the error when installing the app-per-port sample:

15:24:56,119 ERROR [JAASRealm] Class org.apache.geronimo.security.realm.providers.GeronimoUserPrincipal not found! Class not added. 15:24:56,119 ERROR [JAASRealm] Class org.apache.geronimo.security.realm.providers.GeronimoGroupPrincipal not found! Class not added.
15:24:56,179 ERROR [ProxyCollection] Listener threw exception
java.lang.IllegalArgumentException: addChild: Child name 'localhost' is not unique at org .apache .catalina.core.ContainerBase.addChildInternal(ContainerBase.java:781) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java: 771) at org.apache.catalina.core.StandardEngine.addChild(StandardEngine.java: 262) at org.apache.geronimo.tomcat.EngineGBean.addHost(EngineGBean.java: 182) at org.apache.geronimo.tomcat.EngineGBean.access $000(EngineGBean.java:47) at org.apache.geronimo.tomcat.EngineGBean $1.memberAdded(EngineGBean.java:143) at org .apache .geronimo .gbean.runtime.ProxyCollection.addTarget(ProxyCollection.java:102) at org .apache .geronimo .gbean .runtime .GBeanCollectionReference.targetAdded(GBeanCollectionReference.java: 96) at org .apache .geronimo .gbean .runtime .GBeanCollectionReference.addTarget(GBeanCollectionReference.java:180) at org.apache.geronimo.gbean.runtime.GBeanCollectionReference $1.running(GBeanCollectionReference.java:110) at org .apache .geronimo .kernel .basic .BasicLifecycleMonitor.fireRunningEvent(BasicLifecycleMonitor.java: 176) at org.apache.geronimo.kernel.basic.BasicLifecycleMonitor.access $300(BasicLifecycleMonitor.java:44) at org.apache.geronimo.kernel.basic.BasicLifecycleMonitor $RawLifecycleBroadcaster.fireRunningEvent(BasicLifecycleMonitor.java: 254) at org .apache .geronimo .gbean .runtime.GBeanInstanceState.attemptFullStart(GBeanInstanceState.java: 294) at org .apache .geronimo .gbean.runtime.GBeanInstanceState.start(GBeanInstanceState.java:102) at org .apache .geronimo .gbean .runtime.GBeanInstanceState.startRecursive(GBeanInstanceState.java: 124) at org .apache .geronimo .gbean.runtime.GBeanInstance.startRecursive(GBeanInstance.java:555) at org .apache .geronimo .kernel.basic.BasicKernel.startRecursiveGBean(BasicKernel.java:379) at org .apache .geronimo .kernel .config .ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java: 456) at org .apache .geronimo .kernel .config .KernelConfigurationManager.start(KernelConfigurationManager.java:188) at org .apache .geronimo .kernel .config .SimpleConfigurationManager .startConfiguration(SimpleConfigurationManager.java:562) at org .apache .geronimo .kernel .config .SimpleConfigurationManager .startConfiguration(SimpleConfigurationManager.java:543) at org .apache .geronimo .system .plugin.PluginInstallerGBean.install(PluginInstallerGBean.java:684) at org .apache .geronimo .system .plugin.PluginInstallerGBean.install(PluginInstallerGBean.java:602) at org .apache .geronimo .system .plugin.PluginInstallerGBean.install(PluginInstallerGBean.java:598) at org.apache.geronimo.system.plugin.PluginInstallerGBean $3.run(PluginInstallerGBean.java:749)
        at org.apache.geronimo.pool.ThreadPool$1.run(ThreadPool.java:214)
at org.apache.geronimo.pool.ThreadPool $ContextClassLoaderRunnable.run(ThreadPool.java:344) at java.util.concurrent.ThreadPoolExecutor $Worker.runTask(ThreadPoolExecutor.java:650) at java.util.concurrent.ThreadPoolExecutor $Worker.run(ThreadPoolExecutor.java:675)
        at java.lang.Thread.run(Thread.java:613)
15:24:56,659 WARN  [MapperListener] Unknown default host: localhost


BTW, I think the JAASRealm error is new this week since I believe that I saw the above error without the JAASRealm errors last when when I attempted to deploy this sample.


After applying these changes I still get these errors:
15:40:14,522 ERROR [JAASRealm] Class org.apache.geronimo.security.realm.providers.GeronimoUserPrincipal not found! Class not added. 15:40:14,523 ERROR [JAASRealm] Class org.apache.geronimo.security.realm.providers.GeronimoGroupPrincipal not found! Class not added. 15:40:14,524 ERROR [JAASRealm] Class org.apache.geronimo.security.realm.providers.GeronimoUserPrincipal not found! Class not added. 15:40:14,524 ERROR [JAASRealm] Class org.apache.geronimo.security.realm.providers.GeronimoGroupPrincipal not found! Class not added.
15:40:15,132 WARN  [MapperListener] Unknown default host: localhost1
15:40:15,297 WARN  [MapperListener] Unknown default host: localhost2

I'm not sure these are critical. I don't think we are actually using the JAASRealm that is complaining. Does the app start and run?

I do recall all these errors from when I was working on it, and it could be that the app just wont work without the changes in rev 664198.

thanks
david jencks




... which makes me think there are changes missing from server/ branches/2.1 for the localhost change.

Joe


[EMAIL PROTECTED] wrote:
Author: djencks
Date: Fri Jun  6 16:43:39 2008
New Revision: 664199
URL: http://svn.apache.org/viewvc?rev=664199&view=rev
Log:
GERONIMO-4109 reverse non-default host-engine relationship
Modified:
geronimo/samples/trunk/samples/app-per-port/app-per-port-tomcat/ src/main/plan/plan.xml Modified: geronimo/samples/trunk/samples/app-per-port/app-per-port- tomcat/src/main/plan/plan.xml
URL: 
http://svn.apache.org/viewvc/geronimo/samples/trunk/samples/app-per-port/app-per-port-tomcat/src/main/plan/plan.xml?rev=664199&r1=664198&r2=664199&view=diff
= = = = = = = = = ===================================================================== --- geronimo/samples/trunk/samples/app-per-port/app-per-port-tomcat/ src/main/plan/plan.xml (original) +++ geronimo/samples/trunk/samples/app-per-port/app-per-port-tomcat/ src/main/plan/plan.xml Fri Jun 6 16:43:39 2008
@@ -65,7 +65,7 @@
<gbean name="TomcatWebConnector2" class="org.apache.geronimo.tomcat.connector.Http11NIOConnectorGBean">
                <attribute name="name">HTTP</attribute>
                <attribute name="host">localhost</attribute>
-                <attribute name="port">8082</attribute>
+                <attribute name="port">8091</attribute>
                <attribute name="maxHttpHeaderSize">8192</attribute>
                <attribute name="maxThreads">150</attribute>
                <attribute name="minSpareThreads">25</attribute>
@@ -108,13 +108,8 @@
        <reference name="DefaultHost">
            <name>TomcatHost1</name>
        </reference>
-        <references name="Hosts">
-            <pattern>
-                <name>TomcatHost1</name>
-            </pattern>
-        </references>
        <reference name="RealmGBean">
-            <name>TomcatJAASRealm</name>
+            <name>NoSecurityRealm</name>
        </reference>
        <!--reference name="TomcatValveChain">
            <name>FirstValve</name>
@@ -124,9 +119,9 @@
<gbean name="TomcatHost1" class="org.apache.geronimo.tomcat.HostGBean"> <attribute name="className">org.apache.catalina.core.StandardHost</attribute>
        <attribute name="initParams">
-            name=localhost
+            name=localhost1
            appBase=
-            workDir=work
+            workDir=work1
        </attribute>
    </gbean>
@@ -151,13 +146,8 @@
        <reference name="DefaultHost">
            <name>TomcatHost2</name>
        </reference>
-        <references name="Hosts">
-            <pattern>
-                <name>TomcatHost2</name>
-            </pattern>
-        </references>
        <reference name="RealmGBean">
-            <name>TomcatJAASRealm</name>
+            <name>NoSecurityRealm</name>
        </reference>
        <!--reference name="TomcatValveChain">
            <name>FirstValve</name>
@@ -167,11 +157,15 @@
<gbean name="TomcatHost2" class="org.apache.geronimo.tomcat.HostGBean"> <attribute name="className">org.apache.catalina.core.StandardHost</attribute>
        <attribute name="initParams">
-            name=localhost
+            name=localhost2
            appBase=
-            workDir=work
+            workDir=work2
        </attribute>
    </gbean>
+ <gbean name="NoSecurityRealm" class="org.apache.geronimo.tomcat.RealmGBean"> + <attribute name = "className ">org.apache.geronimo.tomcat.realm.TomcatEJBWSGeronimoRealm</ attribute>
+    </gbean>
+
 </application>


Reply via email to