[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616740#action_12616740
 ] 

Tim McConnell commented on GERONIMODEVTOOLS-449:
------------------------------------------------

Hi Yun Feng, thanks very much for helping augment our new testsuite. Your patch 
looks very good to me. The only thing you might want to change is to use the 
2.0.2 version of the Geronimo server instead of the 2.0-M6. I think if you add 
a dependency to the testsuite.pom.xml file for the 2.0.2 assembly maven will 
download it for you if you don't have it already in your local m2 repo. 
Something like this:

        <dependency>
            <groupId>org.apache.geronimo.assemblies</groupId>
            <artifactId>geronimo-tomcat6-jee5</artifactId>
            <version>2.0.2</version>
            <type>zip</type>
            <classifier>bin</classifier>
            <scope>test</scope>
        </dependency>


> Refactor testsuite to support both v2.0 and v2.1 server s and code reuse
> ------------------------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-449
>                 URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-449
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.1.2
>            Reporter: YunFeng Ma
>            Assignee: Tim McConnell
>             Fix For: 2.1.2
>
>         Attachments: GERONIMODEVTOOLS-449.patch
>
>
> Made the following change:
> 1. Add a new plugin to reuse the codes: org.apache.geronimo.testsuite.common
> 2. Add a new plugin for server v2.0: org.apache.geronimo.testsuite.v20
> 3. Made other changes to support the above plugins

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to