Re: c-m-p plugin + geronimo plugin with no module-id

[Lin Sun]

Hi,

By looking at the c-m-p code, I found that I can use commonInstance to
do that.  So here is my test pom.xml -

<project>
...
    <build>
        <plugins>
            <plugin>
                <groupId>org.apache.geronimo.buildsupport</groupId>
                <artifactId>car-maven-plugin</artifactId>
                <version>${geronimoVersion}</version>

                <!-- Install as extention to allow 'car' packaging to
be used. -->
                <extensions>true</extensions>

                <configuration>
                    <archive>
                        <!-- Do not include META-INF/maven to avoid
long file problems on windows -->
                        <addMavenDescriptor>false</addMavenDescriptor>
                    </archive>
                    <category>Geronimo Plugins</category>
                    <useMavenDependencies>
                        <value>true</value>
                        <includeVersion>false</includeVersion>
                    </useMavenDependencies>
                    <commonInstance>
                        <plugin-artifact>
                            <geronimo-version>2.2-SNAPSHOT</geronimo-version>
                            <jvm-version>1.5</jvm-version>
                        </plugin-artifact>
                    </commonInstance>
                    <osiApproved>true</osiApproved>
                </configuration>
            </plugin>
        </plugins>
    </build>
</project>

Note that I didn't specify module-id in the plugin-artifact within
commonInstance.   However, the generated geronimo-plugin.xml still has
module-id stuff, from the maven project.   I found code that does
this, and will try write a patch for it.   So ideally, I think the
geronimo-plugin.xml should look like this -

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<geronimo-plugin xmlns="http://geronimo.apache.org/xml/ns/plugins-1.3";
xmlns:ns2="http://geronimo.apache.org/xml/ns/attributes-1.2";>
    <name>Geronimo Plugins :: Web Profile Plugin</name>
    <category>Geronimo Plugins</category>
    <description>This profile provides the little G functionality.</description>
    <url>http://www.apache.org</url>
    <author>The Apache Software Foundation</author>
    <license osi-approved="true">The Apache Software License, Version
2.0</license>
    <plugin-artifact>
        <geronimo-version>2.2-SNAPSHOT</geronimo-version>
        <jvm-version>1.5</jvm-version>
        <dependency>
            ...
        </dependency>
        <source-repository>~/.m2/repository/</source-repository>
    </plugin-artifact>
</geronimo-plugin>

I'll continue working on this, but if anyone has some advice please let me know.

Lin

On Thu, Aug 21, 2008 at 10:26 PM, Lin Sun <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I have been looking at c-m-p plugin and geronimo plugin with no
> module-id today, as David reminded me in the other thread about this
> function.   I'd like to use this function for the custom server
> assembly stuff I am working on, as it is similar as groups of plugins
> I was initially proposing.
>
> It looks like we do have code to handle module-id = null in plugin
> metadata, but i have not been successful in creating a geronimo plugin
> that doesn't have a module-id using c-m-p.  is this possible w/ the
> current c-m-p?     Anyone has an example on this type of geronimo
> plugin?    Would this type of plugin just contain a META-INF directory
> with geronimo-plugin.xml in the directory?
>
> Thanks,
>
> Lin
>