[ 
https://issues.apache.org/jira/browse/GERONIMO-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Jencks reopened GERONIMO-4318:
------------------------------------


The change you reverted is essential to allow multiple servers that use the 
same repository to all be able to install a plugin. Checking the repo for 
whether a plugin is present is not an indication whether it has been installed 
on the current server.  If the plugin is not in any repo, then surely it hasn't 
been installed, but just because it is in the repo does not mean it has gone 
through installation which results typically in mention in some config.xml 
files, copying files into var, etc etc.

I'm going to revert your change as it breaks the plugin farm functionality.

> All the plugins are marked as installable on the install plugins portlet
> ------------------------------------------------------------------------
>
>                 Key: GERONIMO-4318
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4318
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 2.2
>            Reporter: Lin Sun
>            Assignee: Lin Sun
>             Fix For: 2.2
>
>
> All the plugins are marked as installable on the install plugins portlet.   
> We check if a plugin is installable by using pluginInstaller.validatePlugin.  
>  If an exception is thrown, then we set the installable to false.   The throw 
> of MissingDependencyException in validatePlugin method is commented out 
> during rev 696105.
> A proposed fix is to throw ConfigurationAlreadyExistsException when 
> validatePlugin fails because of the configuration is already installed.   
> This seems more reasonable and will also get rid of the confusion message of 
> "Missing Dependency: XXX" when a user attempts to install a plugin that has 
> already been installed using the "deploy install-plugin" command.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to