On Sep 25, 2008, at 7:56 PM, Lin Sun wrote:
If we make all plugins be of type car, how do we support those type
jar plugins that don't get registered with server configuration, such
as boilerplate? Should we use the new no plan option provided by
c-m-p recently in this case?
I think that will work fine. I thought I'd already made such a plugin
but can't remember what it might have been. In any case the change
I'm making is only for javaee apps you deploy with no plan at all.
I'm not sure if additional changes will be needed in the admin console
for plans it generates.
thanks
david jencks
Lin
On Thu, Sep 25, 2008 at 1:16 PM, David Jencks
<[EMAIL PROTECTED]> wrote:
I'm finding some problems with apps packaged as plugins, see
GERONIMO-4323
Here's the text...
AbstractRepository.copyToRepository bases the decision on whether
to unpack
or copy an artifact on the type. Since all it gets is a stream and
artifact,
I don't see any obvious ways to change this behavior: to actually
detect if
something is a plugin you'd have to look at the content, which isn't
available when the decision is made.
I can see several ways out:
1. make all plugins be of type car
2. make packed plugins work (would require a new classloader and
might cause
difficulties with tomcat and openejb integration)
3. copy the file packed, peek inside, and unpack if necessary.
Unless there's strong opposition I'm going to try to implement (1).
Comments?
thanks
david jencks
