On Sep 26, 2008, at 9:13 AM, Jarek Gawor wrote:
Hmm... how is the "installedArtifacts" updated when a plugin gets
uninstalled?
It's not. Uninstalling a plugin is not exactly a deterministic
operation and definitely not closely related to or the inverse of
installing one: installing a plugin unpacks files and configuration
that you may not want to remove, and also pulls in dependencies that
may then be used by other plugins. We should encourage people to
assemble a new server instead of uninstalling plugins.
Also, what should getInstalledPlugins() return? A list of
all plugins in the repo or a list of plugins enabled for the given
server instance?
Which method exactly are you asking about? The config store would
tell you all the plugins that are in the repos known to the server.
The plugin installer would tell you all the plugins that have been
installed on this server instance. These are barely related when you
are running multiple servers off of one geronimo install. For an
example see the plugin farm instructions:
http://cwiki.apache.org/confluence/display/GMOxDOC22/Plugin+based+Farming
thanks
david jencks
Jarek
On Fri, Sep 26, 2008 at 10:55 AM, Lin Sun <[EMAIL PROTECTED]>
wrote:
David, thanks for adding this to keep track of what plugins have been
installed on the server.
I think there is a prob with the change. In InstallModulesMojo.java,
as it set installedPluginsList as null. I think this would cause all
the plugins that came with the server assembly during build time
(using c-m-p) not recorded, as saveHistory and loadHistory only
handle
cases when installedPluginList is not null.
Also, in PluginInstallerGBean.java, I don't see anywhere you specify
where we set the default location of the installedPluginsList file to
"var/config/installedPlugins.properties"... I only see that in the
two test files.
Lin
