Patch applied.  Thanks.

-Donald

Ivan wrote:
True, I have uploaded a file, please help to review it !
Thanks !

2008/11/20 Jason Warner <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>

    Thanks for catching that, Ivan.  Could you submit an updated patch
    to the appropriate jira for the necessary tweak to fix the 2.0 branch?


    On Wed, Nov 19, 2008 at 9:50 PM, Ivan <[EMAIL PROTECTED]
    <mailto:[EMAIL PROTECTED]>> wrote:

         While in G-2.0, we have not added the WADI support, so it seems
        that the reference name for tomcat manager is still "Manager",
        no need to update to TomcatWebAppContext
        .GBEAN_REF_MANAGER_RETRIEVER.
         Sorry for that, I forgot to figure it out while providing the
        patch.


        2008/11/20 <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>

            Geronimo Revision: 719139 built with tests included

            See the full build-2000.log file at
            
http://people.apache.org/builds/geronimo/server/binaries/2.0/20081119/build-2000.log


            See the unit test reports at
            
http://people.apache.org/builds/geronimo/server/binaries/2.0/20081119/unit-test-reports


            -------------------------------------------------------
             T E S T S
            -------------------------------------------------------
            Running org.apache.geronimo.web.deployment.WebAppDConfigTest
            Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time
            elapsed: 0.494 sec
            Running
            
org.apache.geronimo.web.deployment.GenericToSpecificPlanConverterTest
            Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time
            elapsed: 0.341 sec
            Running
            org.apache.geronimo.web25.deployment.SpecSecurityParsingTest
            Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time
            elapsed: 0.32 sec
            Running org.apache.geronimo.web25.deployment.SecurityConfigTest
            Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time
            elapsed: 0.138 sec
            Running
            org.apache.geronimo.web25.deployment.SchemaConversionTest
            Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time
            elapsed: 0.437 sec

            Results :
            Tests run: 15, Failures: 0, Errors: 0, Skipped: 0

            [INFO] [jar:jar]
            [INFO] Building jar:
            
/home/geronimo/geronimo/2.0/modules/geronimo-web-2.5-builder/target/geronimo-web-2.5-builder-2.0.3-SNAPSHOT.jar
            [INFO] [tools:verify-legal-files {execution:
            verify-legal-files}]
            [INFO] Checking legal files in:
            geronimo-web-2.5-builder-2.0.3-SNAPSHOT.jar
            [INFO] [install:install]
            [INFO] Installing
            
/home/geronimo/geronimo/2.0/modules/geronimo-web-2.5-builder/target/geronimo-web-2.5-builder-2.0.3-SNAPSHOT.jar
            to
            
/home/geronimo/.m2/repository/org/apache/geronimo/modules/geronimo-web-2.5-builder/2.0.3-SNAPSHOT/geronimo-web-2.5-builder-2.0.3-SNAPSHOT.jar
            [INFO]
            
----------------------------------------------------------------------------
            [INFO] Building Geronimo :: Tomcat :: Builder
            [INFO]    task-segment: [install]
            [INFO]
            
----------------------------------------------------------------------------
            [INFO] [enforcer:enforce {execution: default}]
            [INFO] [xmlbeans:xmlbeans {execution: default}]
            Time to build schema type system: 0.093 seconds
            Time to generate code: 0.109 seconds
            Time to compile code: 2.51 seconds
            [INFO] [tools:copy-legal-files {execution: install-legal-files}]
            [INFO] Created dir:
            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/target/classes/META-INF
            [INFO] Copying 2 files to
            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/target/classes/META-INF
            [INFO] [groovy:execute {execution: default}]
               [mkdir] Created dir:
            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/target/clover/classes
                [copy] Copying 26 files to
            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/target/clover/classes
            [INFO] [resources:resources]
            [WARNING] Using platform encoding (ANSI_X3.4-1968 actually)
            to copy filtered resources, i.e. build is platform dependent!
            [INFO] skip non existing resourceDirectory
            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/src/main/resources
            [INFO] [compiler:compile]
            [INFO] Compiling 1 source file to
            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/target/classes
            [INFO]
            
------------------------------------------------------------------------
            [ERROR] BUILD FAILURE
            [INFO]
            
------------------------------------------------------------------------
            [INFO] Compilation failure
            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/src/main/java/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilder.java:[369,69]
            cannot find symbol
            symbol  : variable GBEAN_REF_MANAGER_RETRIEVER
            location: class org.apache.geronimo.tomcat.TomcatWebAppContext



            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/src/main/java/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilder.java:[369,69]
            cannot find symbol
            symbol  : variable GBEAN_REF_MANAGER_RETRIEVER
            location: class org.apache.geronimo.tomcat.TomcatWebAppContext


            [INFO]
            
------------------------------------------------------------------------
            [INFO] Trace
            org.apache.maven.BuildFailureException: Compilation failure
            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/src/main/java/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilder.java:[369,69]
            cannot find symbol
            symbol  : variable GBEAN_REF_MANAGER_RETRIEVER
            location: class org.apache.geronimo.tomcat.TomcatWebAppContext


                   at
            
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:560)
                   at
            
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
                   at
            
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
                   at
            
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
                   at
            
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
                   at
            
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
                   at
            org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
                   at
            org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
                   at org.apache.maven.cli.MavenCli.main(MavenCli.java:280)
                   at
            sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                   at
            
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
                   at
            
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
                   at java.lang.reflect.Method.invoke(Method.java:585)
                   at
            org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
                   at
            org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
                   at
            
org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
                   at
            org.codehaus.classworlds.Launcher.main(Launcher.java:375)
            Caused by:
            org.apache.maven.plugin.CompilationFailureException:
            Compilation failure
            
/home/geronimo/geronimo/2.0/modules/geronimo-tomcat6-builder/src/main/java/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilder.java:[369,69]
            cannot find symbol
            symbol  : variable GBEAN_REF_MANAGER_RETRIEVER
            location: class org.apache.geronimo.tomcat.TomcatWebAppContext


                   at
            
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:516)
                   at
            org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:114)
                   at
            
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
                   at
            
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
                   ... 16 more
            [INFO]
            
------------------------------------------------------------------------
            [INFO] Total time: 12 minutes 3 seconds
            [INFO] Finished at: Wed Nov 19 20:17:01 EST 2008
            [INFO] Final Memory: 155M/535M
            [INFO]
            
------------------------------------------------------------------------




-- Ivan




-- ~Jason Warner




--
Ivan

Reply via email to