You are correct, sir.

On Tue, Dec 9, 2008 at 11:18 PM, Jason Dillon <[EMAIL PROTECTED]> wrote:

> Hey, you really should not rely on system environment variables here, as
> that kinda defeats the purpose of using the svn-based controllers for all
> configuration.
>
> I'd recommend you revert this and setup defaults in the controllers.
>
> --jason
>
>
>
> On Dec 10, 2008, at 1:50 AM, [EMAIL PROTECTED] wrote:
>
>  Author: jawarner
>> Date: Tue Dec  9 10:50:26 2008
>> New Revision: 724818
>>
>> URL: http://svn.apache.org/viewvc?rev=724818&view=rev
>> Log:
>> Pull maven opts from agent environment
>>
>> Modified:
>>
>> geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
>>
>> Modified:
>> geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
>> URL:
>> http://svn.apache.org/viewvc/geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy?rev=724818&r1=724817&r2=724818&view=diff
>>
>> ==============================================================================
>> ---
>> geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
>> (original)
>> +++
>> geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/commands/MavenCommand.groovy
>> Tue Dec  9 10:50:26 2008
>> @@ -32,7 +32,7 @@
>>
>>    def mavenHome = 'tools/maven'
>>
>> -    def mavenOpts = null
>> +    def mavenOpts = System.getenv('MAVEN_OPTS')
>>
>>    def repoDir = 'repository'
>>
>>
>>
>>
>


-- 
~Jason Warner

Reply via email to