+1 I added the rat plugin to my local pom and checked each module. There were some files that were flagged as failures - but they were reasonable (i.e. generated files, etc). Built fine w/ tests.
Jay Kevan Miller wrote: > Here's my +1. > > I scanned code using RAT, reviewed artifacts, and ran a build. > > --kevan > > On Jan 26, 2009, at 3:18 PM, Joe Bohn wrote: > >> I uploaded a second distribution of XBean 3.5 which should include the >> NOTICE/LICENSE files in all the appropriate places (I hope). The same >> changes are present in this candidate that were present in the last one: >> * SocketAddress factory example for Alex [1] >> * XBEAN-111 Only register Converters with the VM when requested [2] >> * Make dependencies optional [3] >> * XBEAN-114 generify xbean-naming [4] >> * XBEAN-115 Fix rebind of entry added using deepBind [5] >> * XBEAN-115 similar fix to for WritableContext for consistency [6] >> * try to follow apache policy and not deploy timestamped snapshots [7] >> * Fix classloader name when throwing a CNFE [8] >> * Let the tests pass on non-MacOS OSes [9] >> * XBEAN-120 Search for semi-annotated classes in inheritance tree >> (as if @Inherited's applied) [10] >> * XBEAN-120 Search for semi-annotated classes in inheritance tree >> (as if @Inherited's applied) [11] >> * update copyright years to include 2009 [12] >> * add a siteId property to assist in release [13] >> >> Please help validate this release. I'm a little concerned about >> xbean-spring as I noticed some errors fly by during the release >> process but everything eventually passed successfully. I'll start >> validating this in a Geronimo server image but at the moment it will >> only utilize xbean-naming 3.5. >> >> The staging repository is available at >> http://people.apache.org/~jbohn/staging-repo/xbean/ >> and the tag is available at >> http://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-3.5/ >> >> I've run the rat tool to validate license headers. >> >> Please review and vote: >> [ ] +1 Release XBean 3.5 >> [ ] -1 Do not, because ... >> >> The vote will be open for 72 hours or longer as necessary to validate >> the images and get sufficient participation in the vote. >> >> [1] http://svn.apache.org/viewvc?view=rev&revision=689356 >> [2] http://svn.apache.org/viewvc?view=rev&revision=703580 >> [3] http://svn.apache.org/viewvc?view=rev&revision=705314 >> [4] http://svn.apache.org/viewvc?view=rev&revision=707161 >> [5] http://svn.apache.org/viewvc?view=rev&revision=707227 >> [6] http://svn.apache.org/viewvc?view=rev&revision=707230 >> [7] http://svn.apache.org/viewvc?view=rev&revision=707719 >> [8] http://svn.apache.org/viewvc?view=rev&revision=725706 >> [9] http://svn.apache.org/viewvc?view=rev&revision=729545 >> [10] http://svn.apache.org/viewvc?view=rev&revision=729546 >> [11] http://svn.apache.org/viewvc?view=rev&revision=731945 >> [12] http://svn.apache.org/viewvc?view=rev&revision=737042 >> [13] http://svn.apache.org/viewvc?view=rev&revision=737184 >> >> >> Thanks, >> Joe > >
