[
https://issues.apache.org/jira/browse/GERONIMO-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671023#action_12671023
]
Manu T George commented on GERONIMO-4369:
-----------------------------------------
Ivan,
Regarding 1
I was not able to get the changes to persist on restart from admin console
using the patch you provided. (Remember #2 above In case of stop and start #2
applies that is the reason none are getting saved).
Actually this is due to #2
Regarding 2
Yes too many messages are printed. Try starting openejb module the entire
screen is filled with messages :)
Regarding 3
The j2ee-corba-yoko configuration as you mentioned doesn't restart. But if
you use restartConfiguration it does.
Regarding 4
I built two servers one with restartConfiguration (w/o ur patch) and one
with yours and saw restart takes a lot of time with yours but less time with
the restartConfiguration
The reason for restart itself is to reduce the time taken to start again.
Doing stop and start results in more time taken
5) This is regarding #2. Just pointing out that both patches don't fix it
Regarding your point I thought of that but what I thought was that that use
case occurrence is very rare(I dont see users making changes to parent and
child configurations and restarting the parent that often) and maybe the
overhead of applying overrides to
each child configuration will not be worth it. Smacks of laziness :).I will try
that out and see what the overhead is and update my patch. If the overhead is
too high then I will need figure out a way to applyOverrides only for
configurations that are dirty.
Maybe the applyOverrides method already does that or there is some other way to
check this.
Thank you for analyzing my patch and pointing this out and for contributing all
the other patches that helped.
> The new attribute values are overwrote while restarting the DB pool connector
> -----------------------------------------------------------------------------
>
> Key: GERONIMO-4369
> URL: https://issues.apache.org/jira/browse/GERONIMO-4369
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.2
> Environment: Geronimo 2.2 snapshot
> JDK 1.5
> Windows XP
> Reporter: Ivan
> Assignee: Manu T George
> Priority: Blocker
> Fix For: 2.1.4, 2.2
>
> Attachments: G-4369-0205.patch, Geronimo-4369-01.21.patch,
> Geronimo-4369-11.13.patch, Geronimo-4369-11.17.patch,
> Geronimo-4369-11.19.patch
>
>
> After editing the values in the db pool, then restart it in the console, the
> new values lost.
> When saving the new attribute values, such as user name, the gbeandata in
> the configurationManager is not updated, so while restarting the connector,
> the gbinstance copies those old values from it. So the new persistent values
> do not take effect,
> Do I miss anything, thanks for any comment !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
