[
https://issues.apache.org/jira/browse/GERONIMO-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672099#action_12672099
]
Jarek Gawor commented on GERONIMO-4525:
---------------------------------------
Committed all changes to service_pr.bat and committed the change at line 253 to
geronimo.bat as you suggested (revision 742810). Can you explain why the change
at 309 is necessary? I'm pretty sure that ERRORLEVEL will be reset when
%_EXECJAVA% will be executed.
As to 3) I'll experiment some more to be sure but @endlocal was not resetting
the ERRORLEVEL for me. But @setlocal was.
> No effective exit code for all Windows commands
> -----------------------------------------------
>
> Key: GERONIMO-4525
> URL: https://issues.apache.org/jira/browse/GERONIMO-4525
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: commands
> Affects Versions: 2.1.3
> Environment: MS Windows
> Reporter: Jack Cai
> Assignee: Jarek Gawor
> Fix For: 2.1.4, 2.2
>
> Attachments: Geronimo-4525_Jack.patch
>
>
> There are multiple problems in the current Windows batch commands (including
> geronimo.bat, startup.bat, etc.)
> - It's not recommended to define an environment variable with the name
> ERRORLEVEL. See [1].
> - Set a value to ERRORLEVEL has no effect to the exit code of the batch
> command (so the documented exit code "0" and "1" are not actually there).
> - The value of the ERRORLEVEL variable will also get unset when the
> "@endlocal" command is called.
> [1] http://blogs.msdn.com/oldnewthing/archive/2008/09/26/8965755.aspx
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
