[ 
https://issues.apache.org/jira/browse/DAYTRADER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708651#action_12708651
 ] 

Joe Bohn commented on DAYTRADER-68:
-----------------------------------

Some more comments and questions:
- I noticed that ./daytrader-webonly/daytrader-datasource-plan.xml and 
./daytrader-webonly/src/main/webapp/META-INF/context.xml are missing the Apache 
License header.  Can you please add them with your contribution?
-  We probably need some more description (in the README?) about the datasource 
and how to handle this for Geronimo installations and possibly Tomcat installs 
as well.  I can see where it might be confusing with the 
daytrader-derby-datasource that we also have out there.  Perhaps we need to 
include webonly in this name as well.
- were you working on the tomcat/jetty plugins of this that were discussed on 
the original proposal?

> A version of daytrader for Tomcat 6
> -----------------------------------
>
>                 Key: DAYTRADER-68
>                 URL: https://issues.apache.org/jira/browse/DAYTRADER-68
>             Project: DayTrader
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Web Tier
>    Affects Versions: 2.2
>         Environment: Tomcat 6.0.18
>            Reporter: Forrest Xia
>            Assignee: Forrest Xia
>         Attachments: daytrader-webonly-new.patch, daytrader-webonly-new.zip, 
> daytrader-webonly.patch
>
>
> I have a trimmed version of daytrader for tomcat 6, and want to contribute to 
> daytrader trunk, please help review and commit. thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to