On Jun 3, 2009, at 8:16 AM, Jay D. McHugh (JIRA) wrote:


[ https://issues.apache.org/jira/browse/GERONIMO-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715948 #action_12715948 ]

Jay D. McHugh commented on GERONIMO-4130:
-----------------------------------------

I just checked 2.1.5 to see if the comment function was still working. And it is.

Is it not working in 2.2?

The way to put in comments is to wrap them in a comment element.

example

<comment>This will be preserved</comment>

You should be able to add a comment element at any level of the config.

To get a comment into config.xml with the plugin system we'd need the comment to start in the pom, get into geronimo-plugin.xml, and finally end up in config.xml after installation. I haven't tested this, not sure if anyone else has. On the other hand comments in the plan will disappear for sure..... that gets converted to binary goo immediately.

thanks
david jencks



Unable to preserve comments from plan.xml into config.xml
---------------------------------------------------------

               Key: GERONIMO-4130
               URL: https://issues.apache.org/jira/browse/GERONIMO-4130
           Project: Geronimo
        Issue Type: Improvement
    Security Level: public(Regular issues)
        Components: car-maven-plugin
  Affects Versions: 2.1.x, 2.2
          Reporter: Lin Sun
           Fix For: Wish List


I got a user asking me how to turn off tomcat access log.
It was easy in previous releases, as we could provide comment in config.xml and tell the users to "To disable accesslogging uncomment the following section...". However, with our new config.xml, we don't preserve any comments, which makes hard for users to config things.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to