[
https://issues.apache.org/jira/browse/GERONIMO-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jencks closed GERONIMO-4737.
----------------------------------
Resolution: Fixed
rev 796043.
I had to modify the svn command script extensively:
- in general it's better to do svn mv on your local machine unless you are
movng or copying an entire module. Otherwise there is no way to fine out if the
change breaks everything.
- When I edited the script to operate on my local working copy, it copied
resources to filtered-resources/resources.
The resulting servers seem to build and start OK.
> geronimo source code should follow resource filtering best practice defined
> in genesis.
> ---------------------------------------------------------------------------------------
>
> Key: GERONIMO-4737
> URL: https://issues.apache.org/jira/browse/GERONIMO-4737
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: buildsystem
> Affects Versions: 2.2
> Reporter: Shawn Jiang
> Assignee: David Jencks
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4737_filter_svn_commands_patch.txt,
> G4737_filter_svn_commands_patch.txt, G4737_trunk
>
>
> See the filtering setting in
> http://repo1.maven.org/maven2/org/apache/geronimo/genesis/genesis-default-flava/2.0/genesis-default-flava-2.0.pom
> {code}
> <resources>
> <resource>
> <directory>${project.basedir}/src/main/resources</directory>
> <filtering>false</filtering>
> <includes>
> <include>**/*</include>
> </includes>
> </resource>
> <resource>
>
> <directory>${project.basedir}/src/main/filtered-resources</directory>
> <filtering>true</filtering>
> <includes>
> <include>**/*</include>
> </includes>
> </resource>
> </resources>
> <testResources>
> <testResource>
> <directory>${project.basedir}/src/test/resources</directory>
> <filtering>false</filtering>
> <includes>
> <include>**/*</include>
> </includes>
> </testResource>
> <testResource>
>
> <directory>${project.basedir}/src/test/filtered-resources</directory>
> <filtering>true</filtering>
> <includes>
> <include>**/*</include>
> </includes>
> </testResource>
> </testResources>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
