[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734769#action_12734769 ]
Tim McConnell commented on GERONIMODEVTOOLS-575: ------------------------------------------------ Hi again Delos, got a response today from WTP devlist concerning the usage of a RuntimeException instead of a CoreException (discussed above) and that is what they expect. WTP will rethrow the RuntimeException in order to terminate the "stop" Eclipse job which is exactly what we need. So this works fine on Galileo but we probably need to try it on Ganymede as well to ensure we get the same behavior. Also, I got a good suggestion from them on how to handle the case where there is a failure on the GEP side during setup of the Launch Configuration. Currently, we throw a CoreException from the GeronimoServerBehaviourDelegate.setupLaunchConfiguration() method, which doesn't really do much as it is ignored by both WTP and the server. However, if we catch the exception in setupLaunchConfiguration() ourselves and set an error flag in the Geronimo server configuration indicating that it was not setup properly we can subsequently check that flag in the GeronimoLaunchConfigurationDelegate.launch() method and throw the CoreException from there instead. Supposedly, WTP will then handle it correctly. Is that something you think you could look into ?? Thanks > GEP errors that are logged to the Eclipse error log are not always seen by > end-user > ----------------------------------------------------------------------------------- > > Key: GERONIMODEVTOOLS-575 > URL: > https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-575 > Project: Geronimo-Devtools > Issue Type: Bug > Components: eclipse-plugin > Affects Versions: 2.1.4, 2.2.0 > Reporter: Tim McConnell > Assignee: Tim McConnell > Attachments: 575.patch, 575_new.patch, 575_stopserver.patch > > > For example, when deploying an erroneous war file to the Geronimo server will > result in the following to the Eclispe.log that the end-user may not likely > see..... > !ENTRY org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE Distribution of module failed. See log for details. > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE Unable to resolve resource reference 'jdbc/users' (Could not > auto-map to resource. Try adding a resource-ref mapping to your Geronimo > deployment plan. > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE Search conducted in current module and dependencies: > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/axis//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE ) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE org.apache.geronimo.common.DeploymentException: Unable to resolve > resource reference 'jdbc/users' (Could not auto-map to resource. Try adding > a resource-ref mapping to your Geronimo deployment plan. > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE Search conducted in current module and dependencies: > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/tomcat6/2.1.4/car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [CLASSES: org.apache.geronimo.configs/openejb//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/j2ee-corba-yoko//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/axis//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/axis2//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE [ALL: org.apache.geronimo.configs/openjpa//car] > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE ) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.connector.deployment.ResourceRefBuilder.buildNaming(ResourceRefBuilder.java:216) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.j2ee.deployment.NamingBuilderCollection.buildNaming(NamingBuilderCollection.java:53) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.web25.deployment.AbstractWebModuleBuilder.configureBasicWebModuleAttributes(AbstractWebModuleBuilder.java:842) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.tomcat.deployment.TomcatModuleBuilder.addGBeans(TomcatModuleBuilder.java:347) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.j2ee.deployment.SwitchingModuleBuilder.addGBeans(SwitchingModuleBuilder.java:165) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.j2ee.deployment.EARConfigBuilder.buildConfiguration(EARConfigBuilder.java:647) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:255) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.deployment.Deployer.deploy(Deployer.java:134) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown > Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at java.lang.reflect.Method.invoke(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.gbean.runtime.ReflectionMethodInvoker.invoke(ReflectionMethodInvoker.java:34) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.gbean.runtime.GBeanOperation.invoke(GBeanOperation.java:124) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:867) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:239) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.kernel.KernelGBean.invoke(KernelGBean.java:342) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown > Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at java.lang.reflect.Method.invoke(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.gbean.runtime.ReflectionMethodInvoker.invoke(ReflectionMethodInvoker.java:34) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.gbean.runtime.GBeanOperation.invoke(GBeanOperation.java:124) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:867) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:239) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > org.apache.geronimo.system.jmx.MBeanGBeanBridge.invoke(MBeanGBeanBridge.java:172) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at com.sun.jmx.mbeanserver.DynamicMetaDataImpl.invoke(Unknown > Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at com.sun.jmx.mbeanserver.MetaDataImpl.invoke(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > javax.management.remote.rmi.RMIConnectionImpl.doOperation(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > javax.management.remote.rmi.RMIConnectionImpl.access$100(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(Unknown > Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at java.security.AccessController.doPrivileged(Native Method) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(Unknown > Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at javax.management.remote.rmi.RMIConnectionImpl.invoke(Unknown > Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.reflect.GeneratedMethodAccessor111.invoke(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown > Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at java.lang.reflect.Method.invoke(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.rmi.server.UnicastServerRef.dispatch(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.rmi.transport.Transport$1.run(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at java.security.AccessController.doPrivileged(Native Method) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.rmi.transport.Transport.serviceCall(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at sun.rmi.transport.tcp.TCPTransport.handleMessages(Unknown > Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at > sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(Unknown Source) > !SUBENTRY 1 org.apache.geronimo.st.core 4 0 2009-05-31 15:09:17.859 > !MESSAGE at java.lang.Thread.run(Unknown Source) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.