[ 
https://issues.apache.org/jira/browse/GERONIMO-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734975#action_12734975
 ] 

Ivan commented on GERONIMO-4742:
--------------------------------

I am thinking this issue for a while, here is my current ideas,
In Geronimo 2.2, we use server.xml to hold all our configurations for Tomcat. 
While adding the new connector for the Tomcat, we have three ways to save it, 
The first one is to use ConnectorGBean, which is used in the past. 
   Advantage: Less codes change
   Disadvantage : We have to maintain those configurations in two places
The second way is to use server.xml, which means marshall the new configuration 
to server.xml file with JAXB., 
   Advantage: Only use server.xml to hold the configurations
   Disadvantage: Need to be care some issues, such as how to keep the 
placeholders in the server.xml ? We could not keep the comments in the 
server.xml. We need to be care about the codes, for we have two type 
assembilities: Jetty and Tomcat
The last one is to use a big edit box, like what we do in ActiveMQ portlet
   Advantage: Easy,
   Disadvantage: The users get different experiences between Jetty and Tomcat. 
Personally, I will prefer to the second one and the third one.
Any comment ? Thanks !

> Connector portlets for Tomcat does not work
> -------------------------------------------
>
>                 Key: GERONIMO-4742
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4742
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 2.2
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 2.2
>
>
> After  refactoriing Tomcat integratoin codes, currently, the connector 
> portlet does not work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to