[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748659#action_12748659
 ] 

Delos Dai commented on GERONIMODEVTOOLS-589:
--------------------------------------------

Thanks, Ronger!

Suppose your solution is for first problem. But for problem 2, there is no 
ManagedForm class in eclipse 3.3. If need, we have to complete another 
implementation for eclipse 3.3. Meanwhile, I found the API replaced by 
ManagedForm in eclipse 3.3 is not applicable in eclipse 3.4. So now, it's 
difficult for us to find a common solution for both eclipse 3.3&3.4. 

The problems you find may be a minority in eclipse 3.3. Since latest version of 
eclipse has been 3.5, I suggest to remove eclipse 3.3 from GEP supporting 
platform list.

Any objection?


> If GEP2.2 needs to support Eclipse3.3
> -------------------------------------
>
>                 Key: GERONIMODEVTOOLS-589
>                 URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-589
>             Project: Geronimo-Devtools
>          Issue Type: Wish
>          Components: eclipse-plugin
>    Affects Versions: 2.2.0
>         Environment: Eclipse3.3
>            Reporter: Rodger Zhang
>            Assignee: Tim McConnell
>         Attachments: hasAttribute_not_used.patch
>
>
> If GEP2.2 needs to support Eclipse3.3, there a a few codes required modifying.
> 2 compiling errors exists:
> 1. org.apache.geronimo.st.core.GeronimoLaunchConfigurationDelegate
> ...
> if (configuration.hasAttribute(...))
> ...
> There is no "hasAttribute()" method in previous version.
> 2. org.apache.geronimo.st.v21.ui.ServerPluginPage
> ...
> setManagedForm(managedForm);
> ...
> There is no "setManagedForm()" method in previous version.
> ===================================================================
> For the first point, I have a solution as in patch. Please check if feasible.
> For the second point, a discussion ? Please add comment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to