I went ahead and made the change so we could get the tck tests to build, but the change can be reverted if it turns out to not be something we want to keep.
~Jason Warner On Sun, Oct 11, 2009 at 10:30 PM, Donald Woods <[email protected]> wrote: > Was waiting to here if we really needed to pull in this new dependency into > the assemblies or not.... > > Also, the size of the activemq-webconsole.war is around 30MB, which seems > like a lot to add to our assemblies..... > > > -Donald > > > Jason Warner wrote: > >> Donald, >> >> Is there a reason you didn't make the same changes in the branches/2.2 >> dependencies.xml files? If not, I can make that change. >> >> ~Jason Warner >> >> >> On Fri, Oct 9, 2009 at 9:17 AM, <[email protected] <mailto: >> [email protected]>> wrote: >> >> Author: dwoods >> Date: Fri Oct 9 13:17:20 2009 >> New Revision: 823543 >> >> URL: http://svn.apache.org/viewvc?rev=823543&view=rev >> <http://svn.apache.org/viewvc?rev=823543&view=rev> >> Log: >> update activemq-webconsole depends >> >> Modified: >> >> geronimo/server/trunk/plugins/activemq/activemq-webconsole-jetty/src/main/history/dependencies.xml >> >> geronimo/server/trunk/plugins/activemq/activemq-webconsole-tomcat/src/main/history/dependencies.xml >> >> Modified: >> >> >> geronimo/server/trunk/plugins/activemq/activemq-webconsole-jetty/src/main/history/dependencies.xml >> URL: >> >> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/activemq-webconsole-jetty/src/main/history/dependencies.xml?rev=823543&r1=823542&r2=823543&view=diff >> < >> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/activemq-webconsole-jetty/src/main/history/dependencies.xml?rev=823543&r1=823542&r2=823543&view=diff >> > >> >> >> ============================================================================== >> --- >> >> >> geronimo/server/trunk/plugins/activemq/activemq-webconsole-jetty/src/main/history/dependencies.xml >> (original) >> +++ >> >> >> geronimo/server/trunk/plugins/activemq/activemq-webconsole-jetty/src/main/history/dependencies.xml >> Fri Oct 9 13:17:20 2009 >> @@ -121,4 +121,9 @@ >> <artifactId>xmlpull</artifactId> >> <type>jar</type> >> </dependency> >> + <dependency> >> + <groupId>jivesoftware</groupId> >> + <artifactId>smack</artifactId> >> + <type>jar</type> >> + </dependency> >> </plugin-artifact> >> >> Modified: >> >> >> geronimo/server/trunk/plugins/activemq/activemq-webconsole-tomcat/src/main/history/dependencies.xml >> URL: >> >> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/activemq-webconsole-tomcat/src/main/history/dependencies.xml?rev=823543&r1=823542&r2=823543&view=diff >> < >> http://svn.apache.org/viewvc/geronimo/server/trunk/plugins/activemq/activemq-webconsole-tomcat/src/main/history/dependencies.xml?rev=823543&r1=823542&r2=823543&view=diff >> > >> >> >> ============================================================================== >> --- >> >> >> geronimo/server/trunk/plugins/activemq/activemq-webconsole-tomcat/src/main/history/dependencies.xml >> (original) >> +++ >> >> >> geronimo/server/trunk/plugins/activemq/activemq-webconsole-tomcat/src/main/history/dependencies.xml >> Fri Oct 9 13:17:20 2009 >> @@ -121,4 +121,9 @@ >> <artifactId>xmlpull</artifactId> >> <type>jar</type> >> </dependency> >> + <dependency> >> + <groupId>jivesoftware</groupId> >> + <artifactId>smack</artifactId> >> + <type>jar</type> >> + </dependency> >> </plugin-artifact> >> >> >> >>
