No problem. Quintin Beukes
On Mon, Oct 12, 2009 at 8:18 AM, Ivan <[email protected]> wrote: > Thanks, Quinitin Beukes, could ypu please open a JIRA for it ? and if > possible, attach your diff file to the JIRA. > > 2009/10/12 Quintin Beukes <[email protected]> >> >> Hey, >> >> I found the cause of the test failure. >> >> In the file: {src >> >> root}/plugins/jetty7/geronimo-jetty7/./src/main/java/org/apache/geronimo/jetty7/connector/JettyConnector.java >> Line: 289 >> >> It reads: new String[]{"host", "port", "minThreads", "maxThreads", >> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize", >> "lingerMillis", "protocol", "redirectPort", "connectUrl", >> "maxIdleTimeMs"}, >> Change to: new String[]{"host", "port", "minThreads", "maxThreads", >> "bufferSizeBytes", "headerBufferSizeBytes", "acceptQueueSize", >> "lingerMillis", "redirectPort", "maxIdleTimeMs"}, >> >> Basically removing the "protocol" and "connectUrl" attributes from the >> persistent interface attributes fixes the problem. >> >> "protocol" is static for Jetty BIO connector, so it doesn't need to be >> saved, or can't be specified. >> "connectUrl" is generated on the fly through getConnectUrl(), so can't >> be saved either. >> >> So unless my understanding of what persistentAttributes are is >> incorrect, this seems to be the correct solution? Please correct me if >> I'm wrong. >> >> What caused the problem is that the JettyConnector class doesn't have >> a setter for these attributes, so when XBean searches all the >> specified attributes' setters, it fails when it can't find these. This >> caused the test to fail, because the connector doesn't start again >> after being edited (enters the failed state). >> >> Quintin Beukes > > > > -- > Ivan >
