OK. I got it. I'm curious about the scenario when user can deploy a WAR with BundleContext.installBundle()? Is it included in the programming model of Aries?
Thanks! 2010/1/29 Jarek Gawor <[email protected]> > Delos, > > I'm not sure I understand what you are saying. Nothing in Geronimo > needs to generate this webbundle url. It's the user that will have to > construct the right url to deploy a war file using the osgi api > (BundleContext.installBundle()). > If the user is deploying a war file using the deployer tool (using > jsr88 api) that will NOT invoke the webbundle url handler or use the > rfc66 extender. At least that's how things work right now and so in > effect we have two different ways of converting a war into a bundle. > Maybe that's the point of confusion? > The url handler in Aries already has some defaults for > Bundle-SymbolicName, etc. I don't think these defaults can be > configured and maybe that's something to improve in Aries but I think > they are ok for now. > > Jarek > > On Thu, Jan 28, 2010 at 2:35 AM, Delos <[email protected]> wrote: > > Jarek, > > > > I agree with you that the handler is ready once we start it. > > > > But, IMO, to make use of the URL handler, we may have other work to do. > > According to RFC 66 , at least we need to generate a URL to make the > handler > > invoked. The URL has to follow the URL schema definition in RFC 66. Some > > additional information maybe provided such Bundle-SymbolicName, > > Bundle-Version, etc. First, I think we have to define the default values > of > > these headers for a WAR in G3.0. > > > > The URL generation work may not be included in Web extender, but I think > > it's Web extender related. > > > > What's your opinion? > > > > > > 2010/1/28 Jarek Gawor <[email protected]> > >> > >> Delos, > >> > >> Comments in-lined: > >> > >> On Wed, Jan 27, 2010 at 6:33 AM, Delos <[email protected]> wrote: > >> > Hi Jarek, > >> > > >> > I see what you meant. The tracker will only add WAB once. Sorry for my > >> > misunderstanding. > >> > > >> > I found several items in TODO file. Besides, I think we may also take > >> > these > >> > two items. If possible, I hope to take them. > >> > 1) I note you have added URLHandler package from Aries as a > dependency. > >> > Is > >> > there any plan how to make use of it to convert WAR into WAB? I'd like > >> > to > >> > take it. > >> > >> It's already being used. The handler is configured via Blueprint so as > >> soon as the handler bundle is started everything is setup right. So > >> there is nothing to do from Geronimo side for the handler. We just > >> need to start it. However, there are a few things that can be improved > >> in the handler code itself. For example, I think right now when it > >> creates the bundle it, it keeps the entire content of the bundle in > >> memory as a byte array. We could improve it so that it writes the > >> bundle data to a file instead. Also, there is a bug open on how the > >> handler generates the Import-Package imports. > >> > >> > 2) For the lazy activate WAB, I'm not sure if it's an optional > feature. > >> > Anyway, I hope to get a workaround for it. I will raise a discussion > >> > once I > >> > find any. > >> > >> I'm pretty sure it's an optional feature :). And from my initial > >> analysis while looking at the whole rfc66 stuff it seemed it would be > >> pretty difficult to get Geronimo working with lazy bundles as > >> described in the spec. So at the end I decided not to worry about > >> it... unless there is a clear indication that this feature must be > >> supported. > >> > >> Jarek > > > > > > > > -- > > Best Regards, > > > > Delos > > > -- Best Regards, Delos
