OK, I have committed your patch to 2.1/2.2/trunk, so if the issue has been resolved, please help to close the JIRA. Thanks !
2010/2/26 Ashish Jain (JIRA) <[email protected]> > > [ > https://issues.apache.org/jira/browse/GERONIMO-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838422#action_12838422] > > Ashish Jain commented on GERONIMO-5155: > --------------------------------------- > > Hi Ivan, > > There are 2 ways you can observe the problem > > 1) one is to put a debug point @ > "request.getPortletSession(true).getAttribute(KEYSTORE_DATA_PREFIX + > keystore)" in LockKeystoreHandler . You will see that the string received > has an extra space, that is if keystore name is "test" than you will get > "test ". this results in a null value for KeystoreData and hence the null > pointer exception. > > 2) In admin console in "Keystore" portlet you can see there are two places > you can of lock/unlock a keystore one for "edit" and another for "usage". > Once you take the mouse cursor over each of them, you can observe a visible > difference in the target url @ the bottom pane of the browser- one with > extra space and one w/o an extra space. > > I have used egaed version of the 2.1.4 to test this and can see the same > problem existing in 2.2 with similar uase, however in 2.2 the problem is due > to "Unrecognized portlet action 'lockKeystore'" this is because mode is > being returned as "lockKeystore ". > > Thanks > Ashish > > > Locking a keystore under "Available" results in exception > > ---------------------------------------------------------- > > > > Key: GERONIMO-5155 > > URL: https://issues.apache.org/jira/browse/GERONIMO-5155 > > Project: Geronimo > > Issue Type: Bug > > Security Level: public(Regular issues) > > Components: security > > Affects Versions: 2.1.4, 2.2 > > Environment: geronimo tomcat assembly > > Reporter: Ashish Jain > > Assignee: Ashish Jain > > Fix For: 2.1.5, 2.2.1 > > > > Attachments: 5155_21.patch > > > > > > Llocking a keystore under "Available" tab in Keystore portlet results in > a null pointer on the web browser for 2.1. Here is the exception on 2.1 > > java.lang.NullPointerException > > > org.apache.geronimo.console.keystores.LockKeystoreHandler.actionBeforeView(LockKeystoreHandler.java:43) > > > org.apache.geronimo.console.MultiPagePortlet.processAction(MultiPagePortlet.java:112) > > > org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:218) > > org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:139) > > javax.servlet.http.HttpServlet.service(HttpServlet.java:693) > > javax.servlet.http.HttpServlet.service(HttpServlet.java:806) > > > org.apache.pluto.core.DefaultPortletInvokerService.invoke(DefaultPortletInvokerService.java:167) > > > org.apache.pluto.core.DefaultPortletInvokerService.action(DefaultPortletInvokerService.java:85) > > > org.apache.pluto.core.PortletContainerImpl.doAction(PortletContainerImpl.java:219) > > > org.apache.pluto.driver.PortalDriverServlet.doGet(PortalDriverServlet.java:121) > > javax.servlet.http.HttpServlet.service(HttpServlet.java:693) > > javax.servlet.http.HttpServlet.service(HttpServlet.java:806) > > > org.apache.geronimo.console.filter.PlutoUrlRebuildFilter.doFilter(PlutoUrlRebuildFilter.java:48) > > > org.apache.geronimo.console.filter.XSSXSRFFilter.doFilter(XSSXSRFFilter.java:125) > > For 2.2 the error thrown is "2010-02-23 23:00:56,062 ERROR > [MultiPagePortlet] Unrecognized portlet action 'lockKeystore'" > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > -- Ivan
