[
https://issues.apache.org/jira/browse/GERONIMO-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866965#action_12866965
]
Chi Runhua edited comment on GERONIMO-4130 at 5/13/10 12:29 AM:
----------------------------------------------------------------
I did a little bit investigation and AFAICT, the root cause is that
car-maven-plugin overlooked the comment area during compiling.
IIUC, car-maven-plugin extracts the code within
<config-xml-content>..</config-xml-content> from pom.xml and imports the code
in to config.xml during assembling. However, even though we have <!->..<->
within <config-xml-content> tags, the information was filtered eventually.
While for 2.0 releases, it seems that config.xml is a hard-coded xml file
rather than an assembled one since 2.1.
I can think of 2 ways for this issue:
1. Let car-maven-plugin copy everything within <config-xml-content> tags, then
we can use standard comment tag like <!-><->, or
2. Add a new element such as <comment>, then all information within <comment>
tags will be converted to description info with <!-><-> in config.xml by
car-maven-plugin.
Any thoughts or am I misleading?
Jeff
was (Author: chi runhua):
If you wish to use the comment text you have typed (shown below), please
copy it now. This text will be lost when you leave this screen.
I did a little bit investigation and AFAICT, the root cause is that
car-maven-plugin overlooked the comment area during compiling.
IIUC, car-maven-plugin extracts the code within
<config-xml-content>..</config-xml-content> from pom.xml and imports the code
in to config.xml during assembling. However, even though we have <!->..<->
within <config-xml-content> tags, the information was filtered eventually.
While for 2.0 releases, it seems that config.xml is a hard-coded xml file
rather than an assembled one since 2.1.
I can think of 2 ways for this issue:
1. Let car-maven-plugin copy everything within <config-xml-content> tags, then
we can use standard comment tag like <!-><->, or
2. Add a new element such as <comment>, then all information within <comment>
tags will be converted to description info with <!-><-> in config.xml by
car-maven-plugin.
Any thoughts or am I misleading?
Jeff
> Unable to preserve comments from plan.xml into config.xml
> ---------------------------------------------------------
>
> Key: GERONIMO-4130
> URL: https://issues.apache.org/jira/browse/GERONIMO-4130
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: car-maven-plugin
> Affects Versions: 2.1.x, 2.2
> Reporter: Lin Sun
> Fix For: 2.2.1, Wish List
>
>
> I got a user asking me how to turn off tomcat access log.
> It was easy in previous releases, as we could provide comment in config.xml
> and tell the users to "To disable accesslogging uncomment the following
> section...". However, with our new config.xml, we don't preserve any
> comments, which makes hard for users to config things.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
