Looks good. Two comments:
1) some of the NOTICE files contain a mix of Unix and Windows line endings. I'm
assuming that this is because they were built on a Windows system. I don't see
anything that is wrong or would cause an error, but another reminder of
problems we're encountering with Windows builds
2) I note that the generated Woodstox NOTICE file does not contain the NOTICE
file from the original. Although I was concerned, at first, after reviewing the
original notice file, I'm not so worried. The contents are rather boilerplate
and I don't see anything that really *must* be carried over:
This product currently only contains code developed by authors
of specific components, as identified by the source code files.
Since product implements StAX API, it has dependencies to StAX API
classes.
For additional credits (generally to people who reported problems)
see CREDITS file.
So, here's my +1
--kevan
On Jul 13, 2010, at 10:43 AM, Rick McGuire wrote:
> To allow the Geronimo trunk release to upgrade the some of the components
> used by the server, I'd like
> release new versions of some of the Geronimo bundle components. This
> components are versions of external
> Geronimo dependencies that have been converted into OSGi jars.
>
> This is a single vote for multiple upgraded bundles used by the Geronimo 3.0
> trunk branch.
>
> The RAT and IANAL plugins have been run against of the projects. All tag svn
> versions have been
> successfully built.
>
> Vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
>
> Staging repo:
>
> https://repository.apache.org/content/repositories/orgapachegeronimo-056/
>
> All source repos are relative to location
>
> https://svn.apache.org/repos/asf/geronimo/bundles/tags
>
> and have the same final element as the artifact name.
>
> The following components are being voted on (the bundles-parent has already
> been promoted):
>
> aspectjrt-1.6.8_1
> aspectjweaver-1.6.8_1
> derby-all-10.6.1.0_1
> sxc-jaxb-0.7.3_1
> sxc-runtime-0.7.3_1
> woodstox-4.0.6_1_1
