[
https://issues.apache.org/jira/browse/GERONIMO-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894826#action_12894826
]
Jarek Gawor commented on GERONIMO-5497:
---------------------------------------
There is already test case for DataSourceDefinition annotation in
enterprise-testsuite/datasource-test. Let's not duplicate the test cases! They
can be carefully combined. Also the attached code also itself has duplicated
code which should be eliminated.
Also, let's avoid selenium for simple test cases like this. Use
HttpUrlConnection or HttpClient (as other tests already do). It makes the tests
run much faster.
> Geronimo 3.0 trunk testsuite for commonannotation1.1 new
> features:javax.annotation.sql.DataSourceDefinition and
> javax.annotation.sql.DataSourceDefinitions
> ----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMO-5497
> URL: https://issues.apache.org/jira/browse/GERONIMO-5497
> Project: Geronimo
> Issue Type: Task
> Security Level: public(Regular issues)
> Components: testsuite
> Affects Versions: 3.0
> Environment: OS: name:Linux;version:2.6.24-24-generic
> JVM: Java Version:1.6.0_20;Java Vendor:Sun Microsystems Inc.
> Server :Version :3.0-SNAPSHOT
> Reporter: janel Zhang
> Fix For: 3.0
>
> Attachments: commonannotation1.1-test.patch
>
>
> The testsuite is designed for common annotation 1.1 new
> features:javax.annotation.sql.DataSourceDefinition and
> javax.annotation.sql.DataSourceDefinitions.
> It passs in the environment as following:OS:
> name:Linux;version:2.6.24-24-generic
> JVM: Java Version:1.6.0_20;Java Vendor:Sun Microsystems Inc
> Server :Version :3.0-SNAPSHOT
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
