[ 
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919137#action_12919137
 ] 

Ted Kirby commented on GERONIMODEVTOOLS-599:
--------------------------------------------

I liked your build.xml simplifications, Johannes.  I was inspired to extend 
your ideas and refactor the code so common code only appears once.  I think 
we'll have to tweak it to account for some minor differences between initial 
major eclipse releases and the subsequent SRn releases, but I think we have an 
improved version that will make this much easier.

See my changes in rev 1005697.

I think Delos did your pom changes in GERONIMODEVTOOLS-600, with his excellent 
sun.arch.data.model work.

I also want to apply this build.xml rework to testsuite/eclipse/build.xml, as 
you suggested, but I want to get the testsuite build to work for me first.  I 
am missing some artifacts as noted in GERONIMODEVTOOLS-675.

Thanks again for the patch Johannes.

> Compilation on x86_64 systems, simplifications of the build.xml files, 
> Eclipse 3.5.1, testsuite fixes
> -----------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-599
>                 URL: 
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-599
>             Project: Geronimo-Devtools
>          Issue Type: Improvement
>          Components: eclipse-plugin
>    Affects Versions: 2.2.0
>         Environment: linux x86_64
>            Reporter: Johannes Weberhofer
>            Assignee: Tim McConnell
>         Attachments: gep-x86_64_and_simplifications.patch
>
>
> * Since revision 832984 build on x86_64 systems was broken again. I have 
> fixed the pom.xml file again and replaced i386 architecture by x86; hope, 
> this works on your build environments, too.
> * simplified the build.xml files by replacing the "galileo" parameters by a 
> more general "eclipse" parameter, which makes changes between eclipse 
> releases much easier (changes have to be done in the header sections only). 
> At the same time I have upgraded to galileo version 3.5.1 (SR1)
> * a bug has been fixed in the testsuite, which made the x86_64 target not to 
> depend on the common target. The testsuite runs much better now on x86_64 
> (but still produces an error)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to