[
https://issues.apache.org/jira/browse/GERONIMO-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shawn Jiang updated GERONIMO-5673:
----------------------------------
Affects Version/s: 2.2.2
Fix Version/s: (was: 2.2.1)
2.2.2
won't fix this in 2.2.1 release.
> ModuleMojoSupport ignores stopOnFailure
> ---------------------------------------
>
> Key: GERONIMO-5673
> URL: https://issues.apache.org/jira/browse/GERONIMO-5673
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: geronimo-maven-plugin
> Affects Versions: 2.2.1, 2.2.2
> Environment: OS X 10.6.4, Java 1.6.0_20, Maven 2.2.1
> Reporter: Trygve Sanne Hardersen
> Fix For: 2.2.2
>
> Attachments: geronimo-2.2-1030330-stopOnFailure.patch
>
>
> The stopOnFailure parameter from ReportingMojoSupport is overridden in
> ModuleMojoSupport, which sets the default value to false as opposed to true
> in ReportingMojoSupport. The problem with this is that it can not be
> overridden from the command line or pom.xml.
> The following build command will always succeed:
> mvn geronimo:deploy-module -Ptools
> -DmoduleArchive=/no/such/archive/1.0/no-such-archive-1.0.war
> -DstopOnFailure=true
> I have also created a sample project that demonstrates this:
> svn checkout https://hypobytes.com/svn/ymir/geronimo/test/trunk geronimo-test
> cd geronimo-test && mvn clean install -Pit
> This build should fail because stopOnFailure is set to true in the project's
> POM.
> I'm no Maven expert, but I've created a patch that simply removes the
> stopOnFailure parameter from ModuleMojoSupport and sets the default value to
> false in ReportingMojoSupport. I've not found a way to have it default to
> true in ReportingMojoSupport and false in ModuleMojoSupport. With this patch
> the Geronimo build still succeeds with normal tests, but I've not verified
> that integration tests also succeed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
