Here's my -1. The json licensing doesn't look correct to me. In particular, the json jar file is not properly licensed.
The json source notice file contains the json "license". I'd prefer to see this in the "license" file. Once in the LICENSE file, IMO, it does not need to appear in the NOTICE file. I probably could live with this. However, more severely: The target jar file does not contain any mention of the JSON license file (not that I could find anyway). All I saw was AL v2. This is not correct and clearly needs to be fixed. Everything else looked good -- signatures, checksums, rat (i.e. the pom.xml files have apache source license headers ;-) --kevan On Dec 15, 2010, at 7:02 AM, Rick McGuire wrote: > This is a single vote for releasing 4 new Geronimo bundles that are OSGi > versions of other jar files. The wrappered jars are > > axiom 1.2.8 > axis2 1.5 > scout 1.2.2 > json 20090211 > > The components up for vote are: > > org/apache/geronimo/bundles/axiom-api/1.2.8_1/axiom-api-1.2.8_1-source-release.tar.gz > org/apache/geronimo/bundles/axiom-api/1.2.8_1/axiom-api-1.2.8_1-source-release.zip > > org/apache/geronimo/bundles/axis2/1.5_1/axis2-1.5_1-source-release.tar.gz > org/apache/geronimo/bundles/axis2/1.5_1/axis2-1.5_1-source-release.zip > > org/apache/geronimo/bundles/scout/1.2.2_1/scout-1.2.2_1-source-release.tar.gz > org/apache/geronimo/bundles/scout/1.2.2_1/scout-1.2.2_1-source-release.zip > > org/apache/geronimo/bundles/json/20090211_1/json-20090211_1-source-release.tar.gz > org/apache/geronimo/bundles/json/20090211_1/json-20090211_1-source-release.zip > > from the staging repository at: > > https://repository.apache.org/content/repositories/orgapachegeronimo-024/ > > The source repos are: > > https://svn.apache.org/repos/asf/geronimo/bundles/tags/axiom-api-1.2.8_1 > https://svn.apache.org/repos/asf/geronimo/bundles/tags/axis2-1.5_1 > https://svn.apache.org/repos/asf/geronimo/bundles/tags/scout-1.2.2_1 > https://svn.apache.org/repos/asf/geronimo/bundles/tags/json-20090211_1 > > Vote will be open for 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > > Rick
