[ 
https://issues.apache.org/jira/browse/GERONIMO-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267304#comment-13267304
 ] 

Forrest Xia commented on GERONIMO-6309:
---------------------------------------

If the patch is to fix the comment description, then we need to blur the 
version number and tell the user the version should be updated according to the 
geronimo version they are using.

Please revise this patch, thank you!
                
> The usage of ConfiguredEncryption is wrong in the comment block
> ---------------------------------------------------------------
>
>                 Key: GERONIMO-6309
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6309
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: general
>    Affects Versions: 2.1.7, 2.1.8
>         Environment: java version "1.6.0"
> Java(TM) SE Runtime Environment (build pwi3260sr10-20111208_01(SR10))
> IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Windows 7 x86-32 
> jvmwi3260sr10-201112
> 07_96808 (JIT enabled, AOT enabled)
> J9VM - 20111207_096808
> JIT  - r9_20111107_21307ifx1
> GC   - 20110519_AA)
> JCL  - 20111104_02
>            Reporter: Saphen Qiu
>            Assignee: Saphen Qiu
>            Priority: Minor
>              Labels: ConfiguredEncryption,configured,password,gbean,rmi-naming
>             Fix For: 2.1.8
>
>         Attachments: ConfiguredEncryption.java.patch
>
>
> The description of ConfiguredEncryption usage is wrong:
> * <gbean name="ConfiguredEncryption">
> * <attribute name="path">var/security/ConfiguredSecretKey.ser</attribute>
> * <reference 
> name="ServerInfo"><pattern><name>ServerInfo</name></pattern></reference>
> * </gbean>
> Here is the correct one:
>  * <gbean 
> name="org.apache.geronimo.framework/rmi-naming/2.1.8/car?j2eeType=GBean,name=ConfiguredEncryption"
>  gbeanInfo="org.apache.geronimo.system.util.ConfiguredEncryption">
>  *  <attribute name="path">var/security/ConfiguredSecretKey.ser</attribute>
>  *  <reference name="ServerInfo">
>  *     <pattern>
>  *       <name>ServerInfo</name>
>  *     </pattern>
>  *  </reference>
>  * </gbean>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to