On May 9, 2013, at 1:17 PM, Alan Cabrera <[email protected]> wrote:
> I got > > [ERROR] Failed to execute goal > org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:check (default-cli) on project > tomcat-parent-7.0.39: Too many unapproved licenses: 1 -> [Help 1] > > for a mvn rat: check. Do we care? Depending on the file(s), we care… Here are the files that I see that are flagged by RAT: !????? ./DEPENDENCIES !????? ./HowTo.txt N ./LICENSE N ./NOTICE ./jasper-el/src/main/java/org/apache/el/parser/ELParser.java ./jasper-el/src/main/java/org/apache/el/parser/ELParserConstants.java ./jasper-el/src/main/java/org/apache/el/parser/ELParserTokenManager.java ./jasper-el/src/main/java/org/apache/el/parser/ELParserTreeConstants.java ./jasper-el/src/main/java/org/apache/el/parser/JJTELParserState.java ./jasper-el/src/main/java/org/apache/el/parser/Node.java ./jasper-el/src/main/java/org/apache/el/parser/ParseException.java ./jasper-el/src/main/java/org/apache/el/parser/SimpleCharStream.java ./jasper-el/src/main/java/org/apache/el/parser/Token.java ./jasper-el/src/main/java/org/apache/el/parser/TokenMgrError.java The jasper-el files are all machine generated. Here's a sample header: /* Generated By:JavaCC: Do not edit this line. TokenMgrError.java Version 5.0 */ /* JavaCCOptions: */ package org.apache.el.parser; So, these look fine to me. LICENSE/NOTICE/DEPENDENCIES are not an issue. HowTo.txt should have a src license header. Once that's fixed I should be +1... --kevan
