Hi Mark,
I'm seeing a few problems. Looks like I may have missed them in the last 
release. Anyway, I think they need to be fixed. My bad for not seeing sooner...

Missing an Apache source license header: 

xbean-finder/src/test/java/org/apache/xbean/finder/ClassAnnotationFinderTest.java
xbean-finder/src/test/java/org/acme/ClassAnnotatedClass.java
xbean-finder/src/test/java/org/acme/NotAnnotated.java (not absolutely 
necessary, but would be good to see the "Copyright (c) 2011 David Blevins" 
removed. will need his permission or for him to do that)

Everything else is looking pretty good. License/Notice, and build looks good. 
So, looks like I'd be +1, if the above were resolved.

--kevan

On May 28, 2013, at 1:33 PM, Mark Struberg <[email protected]> wrote:

> 
> 
> Hi!
> 
> I'd like to call a VOTE for releasing xbean-3.14
> 
> The staging repo can be found here:
> https://repository.apache.org/content/repositories/orgapachegeronimo-014/
> 
> The tag is https://svn.apache.org/repos/asf/geronimo/xbean/tags/xbean-3.14/
> 
> And here comes the source.zip:
> 
> https://repository.apache.org/content/repositories/orgapachegeronimo-014/org/apache/xbean/xbean/3.14/xbean-3.14-source-release.zip
> 
> sha1: 
> 
> a3dffcaf6672db1543e46b0e7ffa0acf84cdf929
> 
> The VOTE is open for 72h
> 
> [+1] all fine, let's ship it
> [+0] meh don't care
> [-1] nope because it contains a ${blocker}
> 
> 
> LieGrue,
> strub

Reply via email to