[ 
https://issues.apache.org/jira/browse/GERONIMO-6480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204619#comment-14204619
 ] 

Alexandre Garnier commented on GERONIMO-6480:
---------------------------------------------

Hmm, should have attach a test case and I don't remember well this issue.
I think that the idea was with {{mail.mime.setcontenttypefilename}} set to 
{{true}} to compute the content-type from the filename ('*.pdf' => 
'application/pdf') when adding the 'name=xxx' instead of using the default 
'text/plain', because when this option is not set or the {{setDataHandler}} is 
called after, then the 'content-type' was right (in the final e-mail, maybe not 
when calling {{getContentType()}} which will always fallback to 'text/plain')

I will try to reproduce this when I have time and post the use case.

> Wrong attachment 'Content-type' in some conditions
> --------------------------------------------------
>
>                 Key: GERONIMO-6480
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6480
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: mail
>            Reporter: Alexandre Garnier
>            Assignee: Hendrik Saly
>
> When you set an attachment filename before having a Content-type defined, 
> then the Content-type is set to 'text/plain'.
> {code:language=java}
> BodyPart attachmentPart = new MimeBodyPart();
> attachmentPart.setDataHandler(dh);
> attachmentPart.setFileName("test.pdf");
> {code}
> ==> Content-type = 'text/plain'
> {code:language=java}
> BodyPart attachmentPart = new MimeBodyPart();
> attachmentPart.addHeader("Content-Type", "aplication/pdf");
> attachmentPart.setDataHandler(dh);
> attachmentPart.setFileName("test.pdf");
> {code}
> ==> Content-type = 'text/plain' (because setDataHandler reset Headers)
> {code:language=java}
> BodyPart attachmentPart = new MimeBodyPart();
> attachmentPart.setDataHandler(dh);
> attachmentPart.addHeader("Content-Type", "aplication/pdf");
> attachmentPart.setFileName("test.pdf");
> {code}
> ==> Right Content-Type
> {code:language=java}
> System.setProperty("mail.mime.setcontenttypefilename", 
> Boolean.FALSE.toString());
> BodyPart attachmentPart = new MimeBodyPart();
> attachmentPart.setDataHandler(dh);
> attachmentPart.setFileName("test.pdf");
> {code}
> ==> Right Content-Type
> {code:language=java}
> BodyPart attachmentPart = new MimeBodyPart();
> attachmentPart.setFileName("test.pdf");
> attachmentPart.setDataHandler(dh);
> {code}
> ==> Right Content-Type
> It's because of solution of GERONIMO-2091 (SVN rev412720).
> The right solution is in [javamail 
> MimeBodyPart.java|https://java.net/projects/javamail/sources/mercurial/content/mail/src/main/java/javax/mail/internet/MimeBodyPart.java?rev=569]
>  : use direct access to Header (instead of method with default value) and do 
> nothing if not yet defined. This solution could allow to remove the 
> {{MIME_SETCONTENTTYPEFILENAME}} property.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to